Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[postgres] add alloydbadmin & alloydbmetadata to default exclusion list #19061

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Nov 14, 2024

What does this PR do?

Similar to cloudsqladmin, this PR adds alloydbadmin & alloydbmetadata to default list of databases to exclude from autodiscovery and databases to ignore to prevent failures on Postgres on GCP AlloyDB.

Motivation

https://datadoghq.atlassian.net/browse/DBMON-4770

#18783

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (61912ca) to head (0078080).
Report is 6 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
postgres 93.27% <100.00%> (+3.94%) ⬆️
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@lu-zhengda lu-zhengda added this pull request to the merge queue Nov 15, 2024
Merged via the queue into master with commit 4161d4d Nov 15, 2024
50 of 51 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/alloy branch November 15, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants