Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAASINT-3532] DDS: Forcepoint Security Service Edge: Crawler Integration Without Assets #19345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

manan-crest
Copy link
Contributor

What does this PR do?

PR includes skeleton of Forcepoint Security Service Edge integration without any assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live. As per @nathanmadams's suggestion, we are planning to raise separate PR with assets and all necessary information later.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@michaelcretzman
Copy link
Contributor

@manan-crest I see !!! Add list of steps to set up this integration !!! in this PR, so I assume it is not ready for review.

Please notify the Docs Team in the #documentation channel when this PR is ready for our review. Thanks.

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving per the plan to raise separate PRs with assets and all necessary information later

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (724567b) to head (49e6608).
Report is 67 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants