-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced the volume of logging from the botocore
library
#19376
Conversation
8fe3e81
to
d1e1404
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Thanks @Kyle-Neale! And @dkirov-dd for finding setLevel! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kyle-Neale A changelog entry could be useful here, so that the Agent team can track the fix, and in case customers have noticed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment! We still log at the critical level, so we're not totally preventing the logging. Also the people reading the log will be waiting for something like "Reduced the volume of logging from the botocore library".
50b429f
to
89b3d3e
Compare
botocore
logs into the Agentbotocore
library
What does this PR do?
This prevents propagation of
botocore
logs into the Agent.Motivation
This log pattern spams the Agent every time the check is run so we prevent this from happening by setting the
botocore
log level to
CRITICAL
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged