Support prometheus endpoint #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
coignetp
commented
Jul 10, 2020
| # 'consul_raft_replication_installSnapshot': 'raft.replication.installSnapshot', | ||
| # 'consul_raft_replication_heartbeat': 'raft.replication.heartbeat', | ||
| # 'consul_raft_replication_appendEntries_rpc': 'raft.replication.appendEntries.rpc', | ||
| # 'consul_raft_replication_appendEntries_logs': 'raft.replication.appendEntries.logs', |
There was a problem hiding this comment.
Waiting for the consul PRs to be merged and having a new release. Note that we can still merge this PR and add the http and raft.replication metrics prometheus support later.
There was a problem hiding this comment.
Let's merge this PR to support the prometheus endpoint, even if some metrics are missing. We can add them later.
ChristineTChen
requested changes
Jul 10, 2020
hithwen
reviewed
Jul 23, 2020
ChristineTChen
requested changes
Jul 23, 2020
ChristineTChen
previously approved these changes
Jul 24, 2020
Co-authored-by: Christine Chen <ChristineTChen@users.noreply.github.com> Co-authored-by: sarina-dd <57639676+sarina-dd@users.noreply.github.com>
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
Co-authored-by: Christine Chen <ChristineTChen@users.noreply.github.com>
coignetp
force-pushed
the
paul/consul-prometheus
branch
from
3016db7
to
5ad7637
Compare
ChristineTChen
approved these changes
Aug 18, 2020
Comment on lines
+55
to
+57
| raise ConfigurationError( | ||
| 'The DogStatsD method and the Prometheus method are both enabled. Please choose only one.' | ||
| ) |
There was a problem hiding this comment.
Are the supported dogstatsd metrics all available from the prometheus endpoint?
There was a problem hiding this comment.
Yes they should be all available https://www.consul.io/docs/agent/telemetry, even if we don't retrieve them all due to the tag issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Support prometheus endpoint for
consulintegration.Motivation
A prometheus endpoint is available since Consul 1.1.0 (https://github.com/hashicorp/consul/blob/master/CHANGELOG.md#110-may-11-2018) and exposes metrics that are currently directly handled by dogstatsd (see the README https://github.com/DataDog/integrations-core/tree/master/consul#dogstatsd).
Additional Notes
Some of these metrics have information in the name that could be useful as labels.
I opened some PRs to change it if possible.
See:
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached