Skip to content

Conversation

@aa-joshi
Copy link
Contributor

@aa-joshi aa-joshi commented Mar 18, 2024

What does this PR do?

This PR adds metrics and preview dashboard for cockroach cloud latest serverless offerings.

Motivation

Cockroach Cloud support serverless offering. Cockroach Labs would like to improve observability around it by emitting additional metrics along with limited preview dashboard.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

  • make sure that PR is backward compatible in terms of existing integrations.
  • please keep us posted when change is getting deployed in production.

@aa-joshi aa-joshi force-pushed the cockcroach_cloud_update branch 10 times, most recently from 06ee13b to ae94845 Compare March 19, 2024 09:13
@aa-joshi aa-joshi force-pushed the cockcroach_cloud_update branch from ae94845 to 7ffcc8f Compare March 19, 2024 09:24
@aa-joshi aa-joshi marked this pull request as ready for review March 19, 2024 10:39
@aa-joshi aa-joshi requested a review from a team as a code owner March 19, 2024 10:39
@emarsha94 emarsha94 requested review from a team and JoshPatel13 and removed request for a team March 19, 2024 19:11
@jhgilbert jhgilbert added the editorial review Waiting on a more in-depth review from a docs team editor label Mar 19, 2024
Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated dashboards links and other minor edits. Let me know if you have any questions!

Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
…less_overview.json

Co-authored-by: Esther Kim <esthercodes2019@gmail.com>
@aa-joshi aa-joshi requested a review from estherk15 March 26, 2024 10:52
@aa-joshi
Copy link
Contributor Author

@estherk15 Thanks for valuable suggestions! Please take a look at updated PR.

Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes!

@aa-joshi aa-joshi requested a review from JoshPatel13 April 23, 2024 04:56
@JoshPatel13 JoshPatel13 merged commit 60f6b2d into DataDog:master May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants