-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDS: F5 Distributed Cloud integration (V2.0.0) #2457
base: master
Are you sure you want to change the base?
DDS: F5 Distributed Cloud integration (V2.0.0) #2457
Conversation
…efense dashboard.
sourceType: attribute | ||
target: network.destination.port | ||
targetType: attribute | ||
preserveSource: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the preserveSource set to true for some of the attribute-remappers ? Is this not a new integration ? Are you relying on "dst_port" naming when analyzing your logs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is an update integration and we would like to preserve the older values for anyone using the exisiting attributes in their custom created assets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thank you
It does not seem possible for me to add the label required to test on staging: [assets/deploy-logs-staging] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
What does this PR do?
PR for a integration F5 Distributed Cloud 2.0.0
Motivation
-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- During the standard attribute remapping, we preserve certain source attributes to ensure compatibility with older versions without causing conflicts. For other fields, we do not preserve them as per suggested best practices. As a result, filters using these standard attributes will populate values from other integrations, following the current datadog behavior.
Review checklist
no-changelog
label attachedAdditional Notes
The pipeline is encountering failures due to source conflicts. This issue needs to be resolved to ensure smooth pipeline execution.