-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Doppler integration (ECOINT-6) #2460
base: master
Are you sure you want to change the base?
Conversation
Created DOCS-8635 for docs review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some minor edits.
9a42e54
to
1d3680b
Compare
1d3680b
to
752a189
Compare
Thanks all for the feedback! A question for you: Do I need the files added in the "WIP: Add tests" commit? I re-ran I still need to let CI run and collect the test log results. I'll push again once that's done. |
Another question: What should I provide for these manifest values if our integration doesn't produce metrics or provide service checks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion to update the Oauth client id. I believe this should fix the failing validations!
Co-authored-by: london-wharton <london.wharton@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for making that change!
Change Author name to Partner name. This is what shows on the tile so it should be the integration name
What does this PR do?
This PR creates the Doppler log collection integration. This is an API-based integration that uses OAuth to connect Doppler with Datadog. Once connected, Doppler will begin sending activity log data to Datadog.
Motivation
What inspired you to submit this pull request?
Review checklist
no-changelog
label attached