Refactor ping check for clarity and error handling #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@jstanton617 Could you please review this PR when you have a chance? |
masafm
reviewed
Nov 12, 2025
masafm
left a comment
masafm
left a comment
There was a problem hiding this comment.
Have you reviewed or updated the test cases to align with this change?
| # Real execution error (e.g. missing binary, permission, DNS failure) | ||
| # The service check is marked CRITICAL, and the check itself raises an error. | ||
| self.log.info("%s check error (%s)", host, e) | ||
| self.service_check(self.SERVICE_CHECK_NAME, AgentCheck.CRITICAL, custom_tags, message=str(e)) |
There was a problem hiding this comment.
It’s not exactly a correction, but wouldn’t AgentCheck.UNKNOWN instead of AgentCheck.CRITICAL be more appropriate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, when a ping command returned a non-zero exit code, the check raised a CheckException, causing the entire check run to fail. This behavior made the Agent mark the check as ERROR, even for normal network conditions such as a host being temporarily unreachable.
Review checklist
no-changeloglabel attachedAdditional Notes
Testing
• Verified on Linux (RHEL 9) — correct behavior for both reachable and unreachable hosts.
• Verified on Windows Server 2022 — correct behavior for both reachable and unreachable hosts.
• Both environments report accurate service check statuses and metrics, with no false-positive response times.