Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor] shutdown the executor on cue, dont leak #126

Merged
merged 2 commits into from
Nov 12, 2020
Merged

[processor] shutdown the executor on cue, dont leak #126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24d105f
[processor] shutdown the executor on cue, dont leak
truthbk Nov 12, 2020
404bfd5
[processor] shutdown after setting boolean intent
truthbk Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/main/java/com/timgroup/statsd/StatsDNonBlockingProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,4 @@ protected boolean send(final Message message) {

return false;
}

void shutdown() {
shutdown = true;
}
}
2 changes: 1 addition & 1 deletion src/main/java/com/timgroup/statsd/StatsDProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,11 @@ public void run() {
}

boolean isShutdown() {
executor.shutdown();
return shutdown;
}

void shutdown() {
executor.shutdown();
shutdown = true;
olivielpeau marked this conversation as resolved.
Show resolved Hide resolved
}
}