Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 22.0.1-tem as SDKMAN env Java #110

Closed
wants to merge 3 commits into from
Closed

Set 22.0.1-tem as SDKMAN env Java #110

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ab434f
Set 22.0.1-tem as SDKMAN env Java
MattAlp Jun 25, 2024
1edc550
retrigger checks
MattAlp Aug 13, 2024
728b853
Merge branch 'main' into mattalp/add-sdkmanrc
MattAlp Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .sdkmanrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Enable auto-env through the sdkman_auto_env config
# Add key=value pairs of SDKs to use below
java=22.0.1-tem
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a matching README requirement section if we use sdkman ?

Copy link
Contributor Author

@MattAlp MattAlp Jun 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you put in it? Prompt the user to install sdkman?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are currently pre-requisites to building the project.
Using sdkman simplifies this. We can mention it as an alternative or we can just put this as the standard path to building the project.
This is not a blocking comment to merge.

Loading