Fix checkpoint interval in GetLineNumberTableLeakTest comment #328

Copilot · 2026-01-10T21:56:58Z

Comment on lines 174-175 incorrectly stated "200 restarts" when the test uses checkpointInterval = 5.

Changes:

Updated comment thresholds to reflect actual 5-restart intervals:
- With fix: < 5 KB per 5 restarts (was < 2 MB per 200 restarts)
- Without fix: 10-20 KB per 5 restart interval (was ~3.2 MB per 200 restarts)
Now aligns with the 10 KB per-interval assertion threshold

// Assert that Internal category doesn't show super-linear growth
// With fix: Internal should plateau after warmup (< 5 KB per 5 restarts from minor JVM allocations)
// Without fix: line table leaks accumulate → 10-20 KB per 5 restart interval

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: jbachorik <738413+jbachorik@users.noreply.github.com>

pr-commenter · 2026-01-10T23:46:05Z

Benchmarks [x86_64 wall]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	wall	wall
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

pr-commenter · 2026-01-10T23:46:53Z

Benchmarks [x86_64 cpu]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	cpu	cpu
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

pr-commenter · 2026-01-10T23:47:07Z

Benchmarks [x86_64 memleak]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	memleak	memleak
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 24 unstable metrics.

pr-commenter · 2026-01-10T23:47:08Z

Benchmarks [aarch64 wall]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	wall	wall
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 24 unstable metrics.

pr-commenter · 2026-01-10T23:47:39Z

Benchmarks [aarch64 cpu,wall]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	cpu,wall	cpu,wall
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

pr-commenter · 2026-01-10T23:48:17Z

Benchmarks [x86_64 memleak,alloc]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	memleak,alloc	memleak,alloc
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

pr-commenter · 2026-01-10T23:48:54Z

Benchmarks [x86_64 cpu,wall,alloc,memleak]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	cpu,wall,alloc,memleak	cpu,wall,alloc,memleak
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 23 unstable metrics.

pr-commenter · 2026-01-10T23:49:28Z

Benchmarks [aarch64 cpu,wall,alloc,memleak]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	cpu,wall,alloc,memleak	cpu,wall,alloc,memleak
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 21 unstable metrics.

pr-commenter · 2026-01-10T23:49:40Z

Benchmarks [aarch64 cpu]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	cpu	cpu
wall	off	off

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 22 unstable metrics.

scenario	Δ mean execution_time	Δ mean rss
scenario:renaissance:scala-doku	better [-4.651s; -1.621s] or [-15.292%; -5.330%]	unstable [-192.319MB; +285.541MB] or [-18.168%; +26.975%]

pr-commenter · 2026-01-10T23:49:45Z

Benchmarks [aarch64 memleak,alloc]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	memleak,alloc	memleak,alloc
wall	off	off

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 23 unstable metrics.

scenario	Δ mean execution_time	Δ mean rss
scenario:renaissance:akka-uct	better [-1.995s; -0.645s] or [-6.482%; -2.095%]	unstable [-242.325MB; +285.047MB] or [-19.479%; +22.913%]

pr-commenter · 2026-01-10T23:49:48Z

Benchmarks [aarch64 alloc]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	alloc	alloc
wall	off	off

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 22 unstable metrics.

scenario	Δ mean execution_time	Δ mean rss
scenario:renaissance:scala-doku	better [-5.237s; -2.515s] or [-17.219%; -8.269%]	unstable [-195.132MB; +276.979MB] or [-18.328%; +26.016%]

pr-commenter · 2026-01-10T23:49:51Z

Benchmarks [aarch64 memleak]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	on	on
modes	memleak	memleak
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 22 unstable metrics.

pr-commenter · 2026-01-10T23:50:04Z

Benchmarks [x86_64 alloc]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	on	on
cpu	off	off
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	alloc	alloc
wall	off	off

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 22 unstable metrics.

pr-commenter · 2026-01-10T23:50:08Z

Benchmarks [x86_64 cpu,wall]

Parameters

	Baseline	Candidate
config	baseline	candidate
ddprof	1.34.4	1.35.0-copilot_sub-pr-327-SNAPSHOT

See matching parameters

	Baseline	Candidate
alloc	off	off
cpu	on	on
iterations	5	5
java	"11.0.28"	"11.0.28"
memleak	off	off
modes	cpu,wall	cpu,wall
wall	on	on

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 22 unstable metrics.

Initial plan

41c57a9

Copilot AI assigned Copilot and jbachorik Jan 10, 2026

Copilot AI mentioned this pull request Jan 10, 2026

Fix GetLineNumberTable JVMTI memory leak and document profiler memory requirements #327

Open

5 tasks

Copilot started work on behalf of jbachorik January 10, 2026 21:57 View session

Fix comment to reflect correct checkpoint interval (5 restarts)

dc68f38

Co-authored-by: jbachorik <738413+jbachorik@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] WIP Address feedback on JVMTI memory leak fix~~ Fix checkpoint interval in GetLineNumberTableLeakTest comment Jan 10, 2026

Copilot AI requested a review from jbachorik January 10, 2026 22:02

Copilot finished work on behalf of jbachorik January 10, 2026 22:02

Fix checkpoint interval in GetLineNumberTableLeakTest comment #328

Are you sure you want to change the base?

Fix checkpoint interval in GetLineNumberTableLeakTest comment #328

Uh oh!

Conversation

Copilot AI commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [x86_64 wall]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [x86_64 cpu]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [x86_64 memleak]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [aarch64 wall]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [aarch64 cpu,wall]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [x86_64 memleak,alloc]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [x86_64 cpu,wall,alloc,memleak]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [aarch64 cpu,wall,alloc,memleak]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [aarch64 cpu]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [aarch64 memleak,alloc]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [aarch64 alloc]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [aarch64 memleak]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [x86_64 alloc]

Parameters

Summary

Uh oh!

pr-commenter bot commented Jan 10, 2026

Benchmarks [x86_64 cpu,wall]

Parameters

Summary

Uh oh!

Reviewers

Assignees

Copilot AI commented Jan 10, 2026 •

edited

Loading