Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to filter tags out of an attribute? #103

Closed
osheroff opened this issue Jun 13, 2016 · 2 comments
Closed

Ability to filter tags out of an attribute? #103

osheroff opened this issue Jun 13, 2016 · 2 comments
Milestone

Comments

@osheroff
Copy link

Hi,
I'm wiring up jmxfetch to a kafka producer JVM. It includes a "client-id" tag(?) that I'd like to filter out, as historically large number of unique tags have been problematic to our datadog install. Is this possible with jmxfetch?

The log line when it discovers the metric:

2016-06-13 21:55:08,313 | DEBUG| Instance | Getting attributes for bean: kafka.producer:type=producer-node-metrics,client-id=9388b6bb-539b-4bc5-8d60-14be420574d6,node-id=node-8
2016-06-13 21:55:08,319 | DEBUG| Instance | Attribute: kafka.producer:type=producer-node-metrics,client-id=9388b6bb-539b-4bc5-8d60-14be420574d6,node-id=node-8 : javax.management.MBeanAttributeInfo[description=The average number of requests sent per second., name=request-rate, type=double, read-only, descriptor={}] has attributeInfo simple type
2016-06-13 21:55:08,322 | DEBUG| Instance | Attribute: kafka.producer:type=producer-node-metrics,client-id=9388b6bb-539b-4bc5-8d60-14be420574d6,node-id=node-8 : javax.management.MBeanAttributeInfo[description=The average size of all requests in the window.., name=request-size-avg, type=double, read-only, descriptor={}] has attributeInfo simple type
2016-06-13 21:55:08,326 | DEBUG| Instance | Attribute: kafka.producer:type=producer-node-metrics,client-id=9388b6bb-539b-4bc5-8d60-14be420574d6,node-id=node-8 : javax.management.MBeanAttributeInfo[description=, name=incoming-byte-rate, type=double, read-only, descriptor={}] has attributeInfo simple type
@yannmh
Copy link
Member

yannmh commented Jun 14, 2016

Thanks for reporting the issue and providing a use case @osheroff .

I am afraid this is not something JMXFetch can do right now. I am adding a note to our triage and will follow back to you: I'll believe we should work on such a feature for the next release.

@yannmh yannmh added this to the Triage milestone Jun 14, 2016
@yannmh yannmh modified the milestones: 0.12.0, Triage Aug 22, 2016
@yannmh
Copy link
Member

yannmh commented Aug 22, 2016

@osheroff we are going to move forward and add support for tag filtering with Datadog Agent 5.9.

To prevent multiple MBeans from being submitted with the same metric names and tags (resulting from the removal of an attribute's tag) and overriding each other, the corresponding metrics would be submitted with the histogram metric type, i.e.

kafka.producer.$name.avg
kafka.producer.$name.min
kafka.producer.$name.max
kafka.producer.$name.med
kafka.producer.$name.count

@yannmh yannmh modified the milestones: 0.12.0, 0.13.0 Sep 7, 2016
hush-hush added a commit that referenced this issue Dec 7, 2016
This is usefull to filter out unique tags like host/client id, ...
This may/should be use in combination with the 'histogram' metric_type to avoid loosing metric points.
hush-hush added a commit that referenced this issue Dec 8, 2016
This is usefull to filter out unique tags like host/client id, ...
This may/should be use in combination with the 'histogram' metric_type to avoid loosing metric points.
hush-hush added a commit that referenced this issue Dec 8, 2016
This is usefull to filter out unique tags like host/client id, ...
This may/should be use in combination with the 'histogram' metric_type to avoid loosing metric points.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants