Adjust time advancement to be done by State #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2024
This was referenced Oct 22, 2024
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
3e3abe8
to
df19761
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
3eca4b6
to
33ef3c3
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
df19761
to
eaf4a71
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
33ef3c3
to
1c4ee6a
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
eaf4a71
to
9b9a9b3
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
1c4ee6a
to
39ae8e6
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
9b9a9b3
to
18666dd
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
39ae8e6
to
7a18465
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
18666dd
to
1c58312
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
7a18465
to
f48b2c9
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
1c58312
to
f1182ba
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
f48b2c9
to
cfe6cf9
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
f1182ba
to
4bae0c5
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
cfe6cf9
to
d80ba3e
Compare
This was referenced Oct 25, 2024
Merged
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
762052b
to
23f5cf9
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
efa1cf9
to
b72b315
Compare
goxberry
approved these changes
Oct 28, 2024
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
23f5cf9
to
41ba656
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
b72b315
to
fa59a04
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
from
41ba656
to
42034fc
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
fa59a04
to
973c1c4
Compare
blt
force-pushed
the
blt/avoid_extra_name_lookup
branch
2 times, most recently
from
10beb10
to
278aaf9
Compare
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
973c1c4
to
a4734f1
Compare
blt
changed the base branch from
blt/avoid_extra_name_lookup
to
graphite-base/1053
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
a4734f1
to
ca57ac5
Compare
blt
force-pushed
the
graphite-base/1053
branch
from
278aaf9
to
9479360
Compare
I'm working now to get rotation logic introduced in State. The first step is to move time advancement to a single place in State -- the advance time function -- although reads and what not in File still induce advances I think. All will be smoothed out eventually. Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
blt
force-pushed
the
blt/adjust_time_advancement_to_be_done_by_state
branch
from
ca57ac5
to
11fcc8c
Compare
Merge activity
|
This was referenced Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I'm working now to get rotation logic introduced in State. The first
step is to move time advancement to a single place in State -- the
advance time function -- although reads and what not in File still
induce advances I think. All will be smoothed out eventually.