Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust Edition 2024 #1251

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Update to Rust Edition 2024 #1251

merged 5 commits into from
Feb 21, 2025

Conversation

blt
Copy link
Collaborator

@blt blt commented Feb 21, 2025

What does this PR do?

This commit updates our Rust toolchain and converts the project
to use edition 2024. Most of the diff here centers around the rand
crate being updated to 0.9 from 0.8 and it's API changes, meant to
accommodate gen becoming a reserved keyword in the new edition.

This commit updates our Rust toolchain and converts the project
to use edition 2024. Most of the diff here centers around the rand
crate being updated to 0.9 from 0.8 and it's API changes, meant to
accomodate `gen` becoming a reserved keyword in the new edition.

Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Copy link
Collaborator Author

blt commented Feb 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@blt blt marked this pull request as ready for review February 21, 2025 00:22
@blt blt requested a review from a team as a code owner February 21, 2025 00:22
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Copy link
Contributor

@GeorgeHahn GeorgeHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the logrotate check failures are fixed

blt added 3 commits February 20, 2025 17:08
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
@blt blt enabled auto-merge (squash) February 21, 2025 01:45
@blt blt merged commit b7303af into main Feb 21, 2025
15 of 17 checks passed
@blt blt deleted the blt/update_to_rust_edition_2024 branch February 21, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants