[NO-TICKET] Fix failing "Ruby gem scaffolding" CI #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our tests use
```ruby
let(:temporary_directory) { "does/not/exist" }
```
and in ruby/fileutils#132 the behavior of
`FileUtils.remove_dir` was tweaked to change the exception that gets
raised when doing `FileUtils.remove_dir` with a directory that doesn't
exist.
I've updated the test clean-up hook with the new exception as well.
May come in handy sometimes (and does not affect what we ship to customers).
Member
Author
BenchmarksComparisonBenchmark execution time: 2025-07-25 08:24:52 Comparing candidate commit 91f5f4d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
- Coverage 71.05% 71.04% -0.02%
==========================================
Files 348 348
Lines 53839 53839
==========================================
- Hits 38254 38248 -6
- Misses 15585 15591 +6
🚀 New features to boost your workflow:
|
ekump
approved these changes
Jul 25, 2025
Member
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the "Ruby gem scaffolding" CI tests that recently started failing, e.g. https://github.com/DataDog/libdatadog/actions/runs/16419817858/job/46553849708:
TL;DR the failure was on ruby-head (aka master, trunk, etc) and there was an explicit behavior change in the Ruby core libraries in ruby/fileutils#132 that caused this.
This PR also includes two other minor tweaks to improve the development/debugging experience in the repo. I recommend reviewing this PR commit-by-commit.
Motivation
Bring CI back to green!
Additional Notes
Some of our tests use
and in ruby/fileutils#132 the behavior of
FileUtils.remove_dirwas tweaked to change the exception that gets raised when doingFileUtils.remove_dirwith a directory that doesn't exist.I've updated the test clean-up hook with the new exception as well.
How to test the change?
Green CI is good!