chore(remote-config): make live debugger optional feature #1246
+17
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonBenchmark execution time: 2025-09-26 07:47:42 Comparing candidate commit f4f7fe7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
BaselineOmitted due to size. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 71.57% 71.68% +0.11%
==========================================
Files 355 355
Lines 56309 56312 +3
==========================================
+ Hits 40302 40368 +66
+ Misses 16007 15944 -63
🚀 New features to boost your workflow:
|
mellon85
reviewed
Sep 26, 2025
| endpoint: self.endpoint.clone(), | ||
| #[cfg(not(feature = "live-debugger"))] | ||
| products: vec![RemoteConfigProduct::ApmTracing], | ||
| #[cfg(feature = "live-debugger")] |
There was a problem hiding this comment.
when another product is added as optional this will be require an even more complex setup.
I think the code must be changed to just add to the vector as needed instead of just trying to jam it in as a one-liner
Contributor
Author
There was a problem hiding this comment.
Indeed, but this is just a test server and I wanted to make sure that I didn't break anything that relied on the existing code.
The RC create really needs to be refactored to better allow for not knowing about all the types and deserialize them itself. That is a bigger task for Q4.
Contributor
There was a problem hiding this comment.
It conveniently allows storing the deserialized data directly on the storage. I'd like to trade as little convenience as possible.
Is there a fundamental benefit of not having to know about all the types? As long as we can simply enable and disable via feature flags, why not actually?
Contributor
Author
There was a problem hiding this comment.
I agree that storing the deserialized data directly is very convenient. I don't advocate for throwing that away, but I think that we should explore if there is another way to split things.
Long term, I don't think that feature flags will be maintainable as we add more products, and there is also the circular nature of the RC data types that I think should be defined with the code that uses them, but that code also depends on RC to get the data.
mellon85
approved these changes
Sep 26, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move live debugger remote configuration functionality behind a feature flag.
Motivation
Avoid pulling in unnecessary dependencies for users that don't need live debugging.