-
Notifications
You must be signed in to change notification settings - Fork 15
feat(profiling): parallel set and string set #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
da142c4 to
5c9f168
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1347 +/- ##
==========================================
+ Coverage 70.87% 70.98% +0.10%
==========================================
Files 385 390 +5
Lines 61838 62586 +748
==========================================
+ Hits 43828 44425 +597
- Misses 18010 18161 +151
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-11-14 18:22:12 Comparing candidate commit 2f6bdcf in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
d9a74b0 to
2f6bdcf
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
This adds
ParallelSet,ParallelSliceSet, andParallelStringSet. It also addsSetOpsandShardedas helpers for those. TheSetOpstrait abstracts some of the differences inSet<T>andSliceSet<T>so thatShardedcan work with either.Motivation
This is another stepping stone for shipping my new profiling API that has long-lived data. These structures are used by the profiles dictionary.
Additional Notes
I ran this locally under thread sanitizer with no issues:
You can run it similarly on your machine by changing the target, if necessary.
How to test the change?
Everything tests as normal.