Skip normalization & obfuscation and coalesce instead #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/agentful-handling
branch
from
73afef7
to
40e13c3
Compare
Turns out the agent ignores the root_span_tags for v0.7 anyway. This is useful to coalesce chunks with common data, allowing us to actually save us from doing redundant requests. As it was currently, the agentful trace sender always sent one trace per request, instead of merging them. We also skip normalization and rely on the agent to do it, for sake of consistency with other tracers and reduce the potentially duplicated work across tracer and agent. We may change that back in future, but for now we've determined it to be the easiest way to work, also with respect to normalization-unaware testing. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/agentful-handling
branch
from
40e13c3
to
eae0df0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
+ Coverage 69.24% 69.27% +0.03%
==========================================
Files 195 195
Lines 26051 26106 +55
==========================================
+ Hits 18039 18086 +47
- Misses 8012 8020 +8
|
pierotibou
reviewed
Jun 7, 2024
Co-authored-by: Pierre Bonet <pierotibou@gmail.com>
Co-authored-by: Pierre Bonet <pierotibou@gmail.com>
Co-authored-by: Pierre Bonet <pierotibou@gmail.com>
pierotibou
approved these changes
Jun 7, 2024
hoolioh
approved these changes
Jun 7, 2024
ekump
reviewed
Jun 7, 2024
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
|
bypassing branch protection and merging at @pierotibou's request. dd-gitlab/report_gitlab_CI_status job is not working as expected. Gitlab manually verified to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the agent ignores the root_span_tags for v0.7 anyway. This is useful to coalesce chunks with common data, allowing us to actually save us from doing redundant requests. As it was currently, the agentful trace sender always sent one trace per request, instead of merging them.
We also skip normalization and rely on the agent to do it, for sake of consistency with other tracers and reduce the potentially duplicated work across tracer and agent. We may change that back in future, but for now we've determined it to be the easiest way to work, also with respect to normalization-unaware testing.