Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use debug = "line-tables-only" #479

Merged
merged 2 commits into from
Jun 7, 2024
Merged

build: use debug = "line-tables-only" #479

merged 2 commits into from
Jun 7, 2024

Conversation

morrisonlevi
Copy link
Contributor

@morrisonlevi morrisonlevi commented Jun 7, 2024

What does this PR do?

Switches from debug = 1 to debug = "line-tables-only".

Motivation

Was looking to try and shrink the builds for PHP (and libdatadog by extension) and noticed that since we're on Rust 1.71 now, we can make this small change.

Additional Notes

For more information about 1 vs line-tables-only, see: https://blog.rust-lang.org/2023/06/01/Rust-1.70.0.html#named-levels-of-debug-information.

How to test the change?

Everything should be the same.

@morrisonlevi morrisonlevi marked this pull request as ready for review June 7, 2024 21:01
@morrisonlevi morrisonlevi requested a review from a team as a code owner June 7, 2024 21:01
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.21%. Comparing base (8ea76f2) to head (f715cdc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   69.21%   69.21%           
=======================================
  Files         195      195           
  Lines       26130    26130           
=======================================
  Hits        18087    18087           
  Misses       8043     8043           
Components Coverage Δ
crashtracker 17.40% <ø> (ø)
datadog-alloc 98.76% <ø> (ø)
data-pipeline 51.30% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.43% <ø> (ø)
ddcommon-ffi 74.15% <ø> (ø)
ddtelemetry 56.11% <ø> (ø)
ipc 84.53% <ø> (ø)
profiling 77.81% <ø> (ø)
profiling-ffi 59.53% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.25% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.36% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.74% <ø> (ø)
trace-protobuf 33.33% <ø> (ø)
trace-utils 91.03% <ø> (ø)

@morrisonlevi
Copy link
Contributor Author

The GitLab failure was cryptic. Rerunning the job, but I don't expect it to be an issue.

@morrisonlevi morrisonlevi merged commit b584007 into main Jun 7, 2024
27 checks passed
@morrisonlevi morrisonlevi deleted the levi/code-size branch June 7, 2024 23:44
@ivoanjo
Copy link
Member

ivoanjo commented Jun 10, 2024

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants