Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf files for stats for new trilean type #480

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

bantonsson
Copy link
Contributor

What does this PR do?

Updates protobuf files to match Datadog Agent.

@bantonsson bantonsson requested review from a team as code owners June 10, 2024 12:22
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 69.18%. Comparing base (b584007) to head (783cf63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   69.21%   69.18%   -0.04%     
==========================================
  Files         195      195              
  Lines       26130    26144      +14     
==========================================
  Hits        18087    18087              
- Misses       8043     8057      +14     
Components Coverage Δ
crashtracker 17.40% <ø> (ø)
datadog-alloc 98.76% <ø> (ø)
data-pipeline 51.30% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.43% <ø> (ø)
ddcommon-ffi 74.15% <ø> (ø)
ddtelemetry 56.11% <ø> (ø)
ipc 84.53% <ø> (ø)
profiling 77.81% <ø> (ø)
profiling-ffi 59.53% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.25% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.36% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.74% <ø> (ø)
trace-protobuf 24.52% <0.00%> (-8.81%) ⬇️
trace-utils 91.03% <ø> (ø)

Copy link
Contributor

@paullegranddc paullegranddc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't quite get the change, because if the struct tags and enums are the same, this is basically a no-op in term of format.

@bantonsson
Copy link
Contributor Author

@paullegranddc it is indeed a no-op on the wire, but the names have been changed in the Datadog Agent protobuf files, so our diff to make sure we don't miss new changes to the files will still fail.

@bantonsson bantonsson merged commit 29c7824 into main Jun 10, 2024
27 checks passed
@bantonsson bantonsson deleted the ban/update-stats-pb-for-trilean-enum branch June 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants