Refactor to reduce signature errors risks #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 69.65% 69.64% -0.01%
==========================================
Files 198 199 +1
Lines 26602 26634 +32
==========================================
+ Hits 18529 18549 +20
- Misses 8073 8085 +12
|
bantonsson
approved these changes
Jun 11, 2024
ddcommon/src/entity_id/mod.rs
Outdated
| /// Set the path to cgroup file to mock it during tests | ||
| /// # Safety | ||
| /// Must not be called in multi-threaded contexts | ||
| pub unsafe fn set_cgroup_file(file: String) { |
There was a problem hiding this comment.
#[allow(unused_variables)] 😉
There was a problem hiding this comment.
I used _file clippy doesn't complain and it seems a bit more specific (even though in such a small function it doesn't make any difference)
VianneyRuhlmann
force-pushed
the
vianney/ddcommon/prevent-signature-errors
branch
2 times, most recently
from
c7780c6
to
e8d3329
Compare
VianneyRuhlmann
force-pushed
the
vianney/ddcommon/prevent-signature-errors
branch
from
e8d3329
to
262ffbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor the fallback for unix specific functions in
entity_idto reduce risks of signature inconsistency between the unix and the fallback implementation.Motivation
Different signatures between fallback and unix versions fixed by #474
Additional Notes
Only refactor, no functional changes