Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Send pid to the receiver #483

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

danielsn
Copy link
Contributor

What does this PR do?

Sends the PID to the receiver from the crashing process

Motivation

Currently, we use getppid, which only works because the receiver is the child of the crashing process. If we want to have a sidecar receiver, we'll need to know the actual pid.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested a review from a team as a code owner June 11, 2024 19:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Project coverage is 69.61%. Comparing base (fc6e92b) to head (7cc7935).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
- Coverage   69.67%   69.61%   -0.07%     
==========================================
  Files         199      199              
  Lines       26606    26631      +25     
==========================================
  Hits        18539    18539              
- Misses       8067     8092      +25     
Components Coverage Δ
crashtracker 17.17% <3.70%> (-0.30%) ⬇️
datadog-alloc 98.63% <ø> (-0.14%) ⬇️
data-pipeline 51.30% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 85.97% <ø> (ø)
ddcommon-ffi 74.15% <ø> (ø)
ddtelemetry 56.37% <ø> (ø)
ipc 84.66% <ø> (ø)
profiling 79.13% <ø> (ø)
profiling-ffi 59.53% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.26% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.36% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 24.52% <ø> (ø)
trace-utils 90.79% <ø> (ø)

Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This seems like something interesting to add tests to.

@danielsn danielsn merged commit a19524f into main Jun 14, 2024
29 checks passed
@danielsn danielsn deleted the dsn/crashtracker-send-pid branch June 14, 2024 18:26
danielsn added a commit that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants