Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump blazesym to release blaze-v0.2.0-rc.0 #487

Merged
merged 11 commits into from
Jul 4, 2024

Conversation

r1viollet
Copy link
Contributor

@r1viollet r1viollet commented Jun 13, 2024

What does this PR do?

Bump blazesym to version v0.2.0-rc.0

Motivation

We now can benefit from remote symbolization.

Additional Notes

None

How to test the change?

The C test and crashtracking tests run with this change.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (6fcf188) to head (f936f22).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   69.67%   69.67%           
=======================================
  Files         199      199           
  Lines       26606    26606           
=======================================
  Hits        18539    18539           
  Misses       8067     8067           
Components Coverage Δ
crashtracker 17.46% <ø> (ø)
datadog-alloc 98.76% <ø> (ø)
data-pipeline 51.30% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 85.97% <ø> (ø)
ddcommon-ffi 74.15% <ø> (ø)
ddtelemetry 56.37% <ø> (ø)
ipc 84.66% <ø> (ø)
profiling 79.13% <ø> (ø)
profiling-ffi 59.53% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.26% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.36% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 24.52% <ø> (ø)
trace-utils 90.79% <ø> (ø)

* Note that the directory containing a symbolization source is always an
* implicit candidate target directory of the highest precedence.
*/
const char *const *debug_dirs;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this API is pretty cool

@r1viollet r1viollet marked this pull request as ready for review June 14, 2024 07:24
@r1viollet r1viollet requested review from a team as code owners June 14, 2024 07:24
@r1viollet r1viollet requested a review from a team as a code owner June 19, 2024 09:51
@r1viollet
Copy link
Contributor Author

Pending clarifications on local failures I was experiencing with some of the crashtracking tests.
@danielsn feel free to merge if you feel everything is OK with crashtracking.

@r1viollet r1viollet force-pushed the r1viollet/blaze-v0.2.0-rc.0 branch from e88850e to 6f8ae87 Compare July 4, 2024 13:50
@pr-commenter
Copy link

pr-commenter bot commented Jul 4, 2024

Benchmarks

Comparison

Parameters

Baseline Candidate
config baseline candidate
git_branch main r1viollet/blaze-v0.2.0-rc.0
git_commit_date 1720005782 1720100315
git_commit_sha ce2afd9 6f8ae87
iterations 710.0 712.0
See matching parameters
Baseline Candidate
ci_job_date 1720101245 1720101245
ci_job_id 562614080 562614080
ci_pipeline_id 38380543 38380543
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Candidate

Candidate benchmark details

Group 1

iterations config cpu_model ci_job_date ci_job_id ci_pipeline_id git_commit_sha git_commit_date git_branch
712.0 candidate Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1720101245 562614080 38380543 6f8ae87 1720100315 r1viollet/blaze-v0.2.0-rc.0
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 70.160µs 70.255µs ± 0.044µs 70.258µs ± 0.028µs 70.279µs 70.334µs 70.357µs 70.376µs 0.17% 0.236 -0.061 0.06% 0.004µs 1 100
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [70.246µs; 70.263µs] or [-0.012%; +0.012%] None None None

Warnings

Scenario: sql/obfuscate_sql_string, Metric: execution_time

Measurements are autocorrelated.

Autocorrelation is present for lags 1..10.

The measurements are not independent, thus confidence intervals
may be less precise.
---------------------------------------------------------------------------
Scenario: sql/obfuscate_sql_string, Metric: execution_time

Sample size is 100, which is lower than 105.

The minimal sample size in case of normal distribution to achieve significance
level of 0.05 for difference of means with effect size Cohen's d = 0.5 must be at
least 105.

The conclusions from confidence intervals may be invalid.
---------------------------------------------------------------------------

Baseline

Baseline benchmark details

Group 1

iterations config cpu_model ci_job_date ci_job_id ci_pipeline_id git_commit_sha git_commit_date git_branch
710.0 baseline Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1720101245 562614080 38380543 ce2afd9 1720005782 main
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 70.378µs 70.449µs ± 0.031µs 70.447µs ± 0.022µs 70.474µs 70.497µs 70.512µs 70.530µs 0.12% 0.105 -0.534 0.04% 0.003µs 1 100
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [70.443µs; 70.455µs] or [-0.009%; +0.009%] None None None

Warnings

Scenario: sql/obfuscate_sql_string, Metric: execution_time

Measurements are autocorrelated.

Autocorrelation is present for lags 1..3.

The measurements are not independent, thus confidence intervals
may be less precise.
---------------------------------------------------------------------------
Scenario: sql/obfuscate_sql_string, Metric: execution_time

Sample size is 100, which is lower than 105.

The minimal sample size in case of normal distribution to achieve significance
level of 0.05 for difference of means with effect size Cohen's d = 0.5 must be at
least 105.

The conclusions from confidence intervals may be invalid.
---------------------------------------------------------------------------

@r1viollet r1viollet merged commit 3142b2d into main Jul 4, 2024
42 checks passed
@r1viollet r1viollet deleted the r1viollet/blaze-v0.2.0-rc.0 branch July 4, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants