Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the generated pb.rs file matches #501

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

bantonsson
Copy link
Contributor

@bantonsson bantonsson commented Jun 24, 2024

What does this PR do?

Adds a check that the auto-generated pb.rs file in trace-protobuf matches the definitions in build.rs.

Motivation

The pb.rs file is auto-generated from the protobuf files and the definitions in build.rs and it's easy to only edit the pb.rs file and forget the definitions in the build.rs file.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.63%. Comparing base (ff7ce41) to head (62cae11).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
+ Coverage   69.39%   69.63%   +0.24%     
==========================================
  Files         201      201              
  Lines       26846    26930      +84     
==========================================
+ Hits        18631    18754     +123     
+ Misses       8215     8176      -39     
Components Coverage Δ
crashtracker 16.70% <ø> (ø)
datadog-alloc 98.76% <ø> (ø)
data-pipeline 51.30% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 85.97% <ø> (ø)
ddcommon-ffi 74.15% <ø> (ø)
ddtelemetry 56.37% <ø> (ø)
ipc 84.66% <ø> (ø)
profiling 78.63% <ø> (+0.64%) ⬆️
profiling-ffi 58.19% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.26% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.36% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.75% <ø> (ø)
trace-protobuf 77.16% <100.00%> (+24.59%) ⬆️
trace-utils 91.61% <ø> (ø)

@bantonsson bantonsson marked this pull request as ready for review June 24, 2024 14:59
@bantonsson bantonsson requested a review from a team as a code owner June 24, 2024 14:59
@bantonsson bantonsson force-pushed the ban/check-genreated-pb.rs branch 2 times, most recently from c482a37 to 32de1b7 Compare June 24, 2024 15:40
@bantonsson bantonsson requested review from a team as code owners June 24, 2024 16:11
@bantonsson bantonsson merged commit 7b5fda2 into main Jun 25, 2024
31 checks passed
@bantonsson bantonsson deleted the ban/check-genreated-pb.rs branch June 25, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants