Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless Mini Agent] Update Azure Resource Group Regex to Account for Windows #504

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

duncanpharvey
Copy link
Contributor

@duncanpharvey duncanpharvey commented Jun 25, 2024

What does this PR do?

Updates regex that extracts the resource group to work on both Linux and Windows Azure Functions.

Motivation

Incorrect resource group extracted for Windows Azure Function.

Additional Notes

How to test the change?

  • Build mini agent locally
  • Deploy Azure Function with mini agent binary in root path
  • Set DD_MINI_AGENT_PATH
    • Azure: /home/site/wwwroot/datadog-serverless-trace-mini-agent

@duncanpharvey duncanpharvey marked this pull request as ready for review June 25, 2024 19:22
@duncanpharvey duncanpharvey requested a review from a team as a code owner June 25, 2024 19:22
@duncanpharvey duncanpharvey requested a review from a team June 25, 2024 19:26
@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2024

Benchmarks

Comparison

Parameters

Baseline Candidate
config baseline candidate
git_branch main duncan-harvey/azure-resource-group
git_commit_date 1719500719 1719510067
git_commit_sha 2d7534d dc24adb
iterations 714.0 711.0
See matching parameters
Baseline Candidate
ci_job_date 1719510307 1719510307
ci_job_id 555434185 555434185
ci_pipeline_id 37762123 37762123
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Candidate

Candidate benchmark details

Group 1

iterations config cpu_model ci_job_date ci_job_id ci_pipeline_id git_commit_sha git_commit_date git_branch
711.0 candidate Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1719510307 555434185 37762123 dc24adb 1719510067 duncan-harvey/azure-resource-group
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 70.248µs 70.349µs ± 0.049µs 70.344µs ± 0.026µs 70.373µs 70.436µs 70.459µs 70.486µs 0.20% 0.394 -0.037 0.07% 0.005µs 1 100
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [70.339µs; 70.359µs] or [-0.014%; +0.014%] None None None

Warnings

Scenario: sql/obfuscate_sql_string, Metric: execution_time

Measurements are autocorrelated.

Autocorrelation is present for lags 1..10.

The measurements are not independent, thus confidence intervals
may be less precise.
---------------------------------------------------------------------------
Scenario: sql/obfuscate_sql_string, Metric: execution_time

Sample size is 100, which is lower than 105.

The minimal sample size in case of normal distribution to achieve significance
level of 0.05 for difference of means with effect size Cohen's d = 0.5 must be at
least 105.

The conclusions from confidence intervals may be invalid.
---------------------------------------------------------------------------

Baseline

Baseline benchmark details

Group 1

iterations config cpu_model ci_job_date ci_job_id ci_pipeline_id git_commit_sha git_commit_date git_branch
714.0 baseline Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1719510307 555434185 37762123 2d7534d 1719500719 main
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 70.009µs 70.105µs ± 0.042µs 70.098µs ± 0.033µs 70.142µs 70.172µs 70.185µs 70.191µs 0.13% 0.064 -0.826 0.06% 0.004µs 1 100
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [70.096µs; 70.113µs] or [-0.012%; +0.012%] None None None

Warnings

Scenario: sql/obfuscate_sql_string, Metric: execution_time

Measurements are autocorrelated.

Autocorrelation is present for lags 1..10.

The measurements are not independent, thus confidence intervals
may be less precise.
---------------------------------------------------------------------------
Scenario: sql/obfuscate_sql_string, Metric: execution_time

Sample size is 100, which is lower than 105.

The minimal sample size in case of normal distribution to achieve significance
level of 0.05 for difference of means with effect size Cohen's d = 0.5 must be at
least 105.

The conclusions from confidence intervals may be invalid.
---------------------------------------------------------------------------

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (2d7534d) to head (dc24adb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #504      +/-   ##
==========================================
+ Coverage   70.35%   70.37%   +0.01%     
==========================================
  Files         204      204              
  Lines       27808    27824      +16     
==========================================
+ Hits        19565    19581      +16     
  Misses       8243     8243              
Components Coverage Δ
crashtracker 16.70% <ø> (ø)
datadog-alloc 98.76% <ø> (ø)
data-pipeline 51.15% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.10% <100.00%> (+0.13%) ⬆️
ddcommon-ffi 74.15% <ø> (ø)
ddtelemetry 59.37% <ø> (ø)
ipc 84.66% <ø> (ø)
profiling 78.63% <ø> (ø)
profiling-ffi 58.19% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 36.19% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 69.70% <ø> (ø)
trace-normalization 97.79% <ø> (ø)
trace-obfuscation 95.75% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 91.21% <ø> (ø)

@duncanpharvey duncanpharvey merged commit 15aa48d into main Jun 27, 2024
32 checks passed
@duncanpharvey duncanpharvey deleted the duncan-harvey/azure-resource-group branch June 27, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants