-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use inplace normalization and add benchmark #506
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
==========================================
+ Coverage 70.41% 70.46% +0.05%
==========================================
Files 204 205 +1
Lines 27890 27939 +49
==========================================
+ Hits 19639 19688 +49
Misses 8251 8251
|
d951b20
to
d6a0f46
Compare
d6a0f46
to
15186f3
Compare
BenchmarksComparisonParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Warnings
BaselineBaseline benchmark detailsGroup 1
Warnings
|
Benchmark summary for performance compared to
The regression for the empty service name case is probably due to the fact that in |
* Fix early exit in ascci case * Make unicode handling faster by checking lowercase class before computing the lowercasing
This reverts commit 46d2da2.
d570cdf
to
32e23d9
Compare
32e23d9
to
be613d2
Compare
43f7d45
to
4ecddd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only some small questions.
What does this PR do?
Work from @paullegranddc in #458
Motivation
Improve trace normalization performance
Additional Notes
How to test the change?