Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Make C example emit a file #539

Merged
merged 6 commits into from
Jul 19, 2024
Merged

Conversation

danielsn
Copy link
Contributor

What does this PR do?

What it says on the tin

Motivation

The current C example was hard to follow, since you needed an instrumented agent to see where the output went. This is cleaner.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested a review from a team as a code owner July 18, 2024 20:38
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.49%. Comparing base (1f350c9) to head (bc72132).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   70.49%   70.49%           
=======================================
  Files         208      208           
  Lines       28397    28397           
=======================================
  Hits        20019    20019           
  Misses       8378     8378           
Components Coverage Δ
crashtracker 25.46% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 50.00% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 86.43% <ø> (ø)
ddcommon-ffi 75.29% <ø> (ø)
ddtelemetry 58.95% <ø> (ø)
ipc 84.13% <ø> (ø)
profiling 78.09% <ø> (ø)
profiling-ffi 56.76% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 35.42% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 54.98% <ø> (ø)
trace-mini-agent 71.14% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.16% <ø> (ø)
trace-utils 91.63% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Jul 18, 2024

Benchmarks

This comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output.

Copy link
Contributor

@morrisonlevi morrisonlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my side.

@danielsn danielsn merged commit 4805ac0 into main Jul 19, 2024
32 checks passed
@danielsn danielsn deleted the dsn/crashtracker-c-example branch July 19, 2024 17:13
ekump pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants