[NO-TICKET] Validate that all public symbols are prefixed in Ruby releases #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eases **What does this PR do?** This PR adds a check during packaging of Ruby releases that all symbols exported in the libdatadog shared library are correctly prefixed. **Motivation:** This allows us to catch any new unprefixed symbols, and thus we're able to rely on libdatadog not exporting symbols that would clash with other libraries that may be loaded in the same Ruby VM. **Additional Notes:** N/A **How to test the change?** You can observe the new check running with `docker-compose run push_to_rubygems`. This is safe to call as it'll stop asking for credentials before actually publishing anything to rubygems.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #573 +/- ##
==========================================
- Coverage 70.28% 70.24% -0.05%
==========================================
Files 214 214
Lines 28785 28802 +17
==========================================
Hits 20231 20231
- Misses 8554 8571 +17
|
BenchmarksComparisonBenchmark execution time: 2024-08-05 08:40:36 Comparing candidate commit 9533108 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics. scenario:normalization/normalize_trace/test_trace
scenario:tags/replace_trace_tags
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
BaselineOmitted due to size. |
AlexJF
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a check during packaging of Ruby releases that all symbols exported in the libdatadog shared library are correctly prefixed.
Motivation
This allows us to catch any new unprefixed symbols, and thus we're able to rely on libdatadog not exporting symbols that would clash with other libraries that may be loaded in the same Ruby VM.
Additional Notes
N/A
How to test the change?
You can observe the new check running with
docker-compose run push_to_rubygems.This is safe to call as it'll stop asking for credentials before actually publishing anything to rubygems.