Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fallback for when memfd is not available on Linux #591

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Aug 21, 2024

WSL is a "Linux" environment, but it does not support the memfd_create syscall. Thus we fall back to other strategies here.

@bwoebi bwoebi requested a review from a team as a code owner August 21, 2024 13:54
@pr-commenter
Copy link

pr-commenter bot commented Aug 21, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-08-22 19:02:21

Comparing candidate commit 6ee4339 in PR branch bob/no-memfd-fallback with baseline commit d980023 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 48 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number_no_luhn/378282246310005

  • 🟥 execution_time [+10.236µs; +10.386µs] or [+13.093%; +13.285%]
  • 🟥 throughput [-1501690.027op/s; -1479649.914op/s] or [-11.739%; -11.567%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 300.834ns 313.157ns ± 13.701ns 306.500ns ± 3.906ns 319.510ns 343.613ns 352.622ns 357.130ns 16.52% 1.420 0.991 4.36% 0.969ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [311.258ns; 315.056ns] or [-0.606%; +0.606%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.147µs 1.346µs ± 0.063µs 1.346µs ± 0.046µs 1.393µs 1.436µs 1.457µs 1.458µs 8.34% -0.515 0.573 4.65% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.338µs; 1.355µs] or [-0.645%; +0.645%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 618.437µs 619.247µs ± 0.494µs 619.170µs ± 0.282µs 619.449µs 620.135µs 620.667µs 622.030µs 0.46% 1.443 4.379 0.08% 0.035µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1607640.192op/s 1614866.592op/s ± 1286.921op/s 1615064.373op/s ± 734.443op/s 1615807.466op/s 1616359.245op/s 1616822.949op/s 1616979.231op/s 0.12% -1.433 4.314 0.08% 90.999op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 386.500µs 390.224µs ± 1.692µs 389.917µs ± 1.081µs 391.244µs 393.472µs 394.663µs 394.972µs 1.30% 0.577 0.055 0.43% 0.120µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2531825.041op/s 2562677.808op/s ± 11083.174op/s 2564649.121op/s ± 7115.139op/s 2570230.831op/s 2578362.327op/s 2582436.610op/s 2587323.643op/s 0.88% -0.554 0.028 0.43% 783.699op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.831µs 191.424µs ± 0.226µs 191.408µs ± 0.166µs 191.576µs 191.827µs 191.982µs 192.172µs 0.40% 0.516 0.085 0.12% 0.016µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5203675.877op/s 5224007.530op/s ± 6176.631op/s 5224445.879op/s ± 4530.859op/s 5228714.356op/s 5232414.635op/s 5235109.647op/s 5240232.408op/s 0.30% -0.510 0.075 0.12% 436.754op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.021µs 45.156µs ± 0.059µs 45.150µs ± 0.043µs 45.198µs 45.256µs 45.305µs 45.324µs 0.39% 0.384 -0.253 0.13% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22063341.648op/s 22145656.010op/s ± 28877.561op/s 22148381.989op/s ± 20899.639op/s 22165712.848op/s 22189618.103op/s 22203378.604op/s 22211874.309op/s 0.29% -0.377 -0.258 0.13% 2041.952op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.296µs 49.933µs ± 0.192µs 49.929µs ± 0.140µs 50.066µs 50.219µs 50.303µs 50.890µs 1.92% 0.455 2.270 0.38% 0.014µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19650185.569op/s 20027160.339op/s ± 76917.353op/s 20028396.302op/s ± 56069.586op/s 20086975.471op/s 20140123.988op/s 20173551.707op/s 20285544.992op/s 1.28% -0.409 2.112 0.38% 5438.878op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [619.178µs; 619.315µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1614688.237op/s; 1615044.947op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [389.990µs; 390.459µs] or [-0.060%; +0.060%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2561141.786op/s; 2564213.829op/s] or [-0.060%; +0.060%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [191.393µs; 191.456µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5223151.508op/s; 5224863.551op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.147µs; 45.164µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22141653.858op/s; 22149658.162op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.906µs; 49.960µs] or [-0.053%; +0.053%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20016500.333op/s; 20037820.344op/s] or [-0.053%; +0.053%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.645µs 2.696µs ± 0.020µs 2.700µs ± 0.005µs 2.703µs 2.737µs 2.743µs 2.744µs 1.65% -0.199 1.137 0.73% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.693µs; 2.699µs] or [-0.102%; +0.102%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 137.582µs 137.942µs ± 0.208µs 137.902µs ± 0.102µs 138.024µs 138.279µs 138.630µs 139.220µs 0.96% 2.013 8.299 0.15% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [137.913µs; 137.971µs] or [-0.021%; +0.021%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 312.476µs 315.553µs ± 2.012µs 315.003µs ± 0.619µs 315.685µs 320.171µs 320.714µs 320.795µs 1.84% 1.314 0.813 0.64% 0.142µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3117252.205op/s 3169164.837op/s ± 20042.943op/s 3174575.267op/s ± 6234.162op/s 3180608.370op/s 3193207.628op/s 3199375.329op/s 3200246.961op/s 0.81% -1.293 0.780 0.63% 1417.250op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.983µs 28.103µs ± 0.056µs 28.093µs ± 0.034µs 28.136µs 28.208µs 28.247µs 28.249µs 0.55% 0.431 -0.074 0.20% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35399073.497op/s 35582917.502op/s ± 70596.228op/s 35595440.704op/s ± 43076.459op/s 35629924.654op/s 35694492.575op/s 35721954.547op/s 35736424.626op/s 0.40% -0.421 -0.082 0.20% 4991.907op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.728µs 16.769µs ± 0.025µs 16.758µs ± 0.014µs 16.787µs 16.820µs 16.840µs 16.849µs 0.54% 0.929 0.258 0.15% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 59351389.904op/s 59634112.457op/s ± 89735.883op/s 59674365.085op/s ± 50940.536op/s 59701031.906op/s 59733601.804op/s 59760603.998op/s 59779464.437op/s 0.18% -0.923 0.240 0.15% 6345.285op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [315.274µs; 315.832µs] or [-0.088%; +0.088%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3166387.078op/s; 3171942.597op/s] or [-0.088%; +0.088%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [28.096µs; 28.111µs] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [35573133.544op/s; 35592701.460op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.765µs; 16.772µs] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/good throughput [59621675.927op/s; 59646548.988op/s] or [-0.021%; +0.021%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 74.553µs 74.782µs ± 0.182µs 74.760µs ± 0.117µs 74.894µs 75.009µs 75.100µs 76.436µs 2.24% 3.887 32.199 0.24% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [74.757µs; 74.807µs] or [-0.034%; +0.034%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 39.356µs 39.912µs ± 0.955µs 39.469µs ± 0.053µs 39.574µs 41.952µs 41.976µs 42.901µs 8.70% 1.706 1.017 2.39% 0.068µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [39.780µs; 40.044µs] or [-0.331%; +0.331%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.613µs 1.614µs ± 0.000µs 1.614µs ± 0.000µs 1.614µs 1.614µs 1.615µs 1.615µs 0.10% 0.533 -0.218 0.03% 0.000µs 1 200
credit_card/is_card_number/ throughput 619132936.144op/s 619742702.949op/s ± 179866.965op/s 619768794.337op/s ± 144982.929op/s 619895391.028op/s 619978990.552op/s 620034584.923op/s 620040712.371op/s 0.04% -0.531 -0.221 0.03% 12718.515op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 104.015µs 105.130µs ± 0.696µs 104.939µs ± 0.200µs 105.177µs 107.092µs 107.432µs 107.649µs 2.58% 2.087 4.022 0.66% 0.049µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 9289420.308op/s 9512396.825op/s ± 62107.855op/s 9529324.344op/s ± 18203.279op/s 9545268.149op/s 9574067.824op/s 9595949.112op/s 9613998.944op/s 0.89% -2.054 3.911 0.65% 4391.689op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 96.661µs 97.379µs ± 0.508µs 97.281µs ± 0.226µs 97.537µs 98.505µs 99.253µs 99.794µs 2.58% 2.025 5.623 0.52% 0.036µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10020620.101op/s 10269439.967op/s ± 53044.674op/s 10279505.236op/s ± 23934.541op/s 10302639.794op/s 10330709.015op/s 10336692.354op/s 10345471.451op/s 0.64% -1.971 5.342 0.52% 3750.825op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.613µs 1.614µs ± 0.003µs 1.614µs ± 0.000µs 1.614µs 1.614µs 1.615µs 1.660µs 2.85% 13.617 187.216 0.20% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 602588154.039op/s 619655272.808op/s ± 1225823.485op/s 619764921.323op/s ± 147902.814op/s 619892642.956op/s 619976705.761op/s 620015903.815op/s 620056331.287op/s 0.05% -13.593 186.782 0.20% 86678.810op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 94.427µs 95.731µs ± 0.711µs 95.653µs ± 0.507µs 96.166µs 97.198µs 97.451µs 97.744µs 2.19% 0.577 -0.095 0.74% 0.050µs 1 200
credit_card/is_card_number/378282246310005 throughput 10230850.868op/s 10446474.430op/s ± 77238.752op/s 10454494.203op/s ± 55157.683op/s 10506676.468op/s 10556011.625op/s 10581907.725op/s 10590227.681op/s 1.30% -0.542 -0.145 0.74% 5461.605op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 94.085µs 94.578µs ± 0.371µs 94.512µs ± 0.188µs 94.702µs 95.261µs 95.598µs 97.167µs 2.81% 2.314 11.056 0.39% 0.026µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 10291533.912op/s 10573465.501op/s ± 41104.146op/s 10580715.068op/s ± 21082.468op/s 10601541.200op/s 10622252.561op/s 10626375.248op/s 10628671.905op/s 0.45% -2.226 10.264 0.39% 2906.502op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 22.438µs 22.800µs ± 0.221µs 22.761µs ± 0.137µs 22.930µs 23.222µs 23.406µs 23.493µs 3.22% 0.727 0.203 0.97% 0.016µs 1 200
credit_card/is_card_number/x371413321323331 throughput 42565372.431op/s 43864021.647op/s ± 421888.247op/s 43935153.950op/s ± 265532.659op/s 44170402.790op/s 44464346.092op/s 44562063.407op/s 44567969.750op/s 1.44% -0.679 0.105 0.96% 29832.004op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.613µs 1.614µs ± 0.001µs 1.614µs ± 0.000µs 1.614µs 1.615µs 1.615µs 1.619µs 0.32% 2.966 20.624 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 617800981.365op/s 619721170.899op/s ± 235678.657op/s 619761171.963op/s ± 137392.300op/s 619879484.050op/s 619993227.089op/s 620023302.640op/s 620101307.225op/s 0.05% -2.951 20.455 0.04% 16664.998op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 85.934µs 86.686µs ± 0.397µs 86.625µs ± 0.245µs 86.928µs 87.457µs 87.855µs 88.317µs 1.95% 0.912 1.500 0.46% 0.028µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 11322848.376op/s 11536122.797op/s ± 52612.830op/s 11544021.915op/s ± 32628.006op/s 11569470.482op/s 11609319.327op/s 11629578.020op/s 11636843.410op/s 0.80% -0.876 1.383 0.45% 3720.289op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 79.064µs 80.268µs ± 0.591µs 80.227µs ± 0.344µs 80.568µs 81.245µs 81.924µs 83.220µs 3.73% 1.001 2.685 0.73% 0.042µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 12016285.624op/s 12458876.951op/s ± 91048.621op/s 12464626.030op/s ± 53280.875op/s 12521531.425op/s 12580491.444op/s 12638723.647op/s 12648042.812op/s 1.47% -0.923 2.346 0.73% 6438.110op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.613µs 1.614µs ± 0.000µs 1.614µs ± 0.000µs 1.614µs 1.614µs 1.615µs 1.615µs 0.09% 0.406 -0.552 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 619163618.557op/s 619734548.534op/s ± 172742.454op/s 619748247.416op/s ± 141500.837op/s 619881935.348op/s 619969221.636op/s 620016965.073op/s 620021667.241op/s 0.04% -0.405 -0.554 0.03% 12214.736op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 87.334µs 88.485µs ± 0.379µs 88.487µs ± 0.244µs 88.735µs 89.085µs 89.307µs 89.528µs 1.18% -0.108 0.064 0.43% 0.027µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11169731.517op/s 11301530.414op/s ± 48426.914op/s 11301092.836op/s ± 31117.325op/s 11332051.609op/s 11382286.511op/s 11412795.945op/s 11450312.674op/s 1.32% 0.135 0.074 0.43% 3424.300op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 94.102µs 94.664µs ± 0.377µs 94.588µs ± 0.253µs 94.906µs 95.326µs 95.808µs 96.081µs 1.58% 0.880 0.716 0.40% 0.027µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 10407846.181op/s 10563867.506op/s ± 41892.716op/s 10572146.100op/s ± 28272.919op/s 10596679.534op/s 10620492.347op/s 10625036.603op/s 10626783.746op/s 0.52% -0.857 0.639 0.40% 2962.262op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 22.436µs 22.822µs ± 0.232µs 22.802µs ± 0.144µs 22.947µs 23.242µs 23.400µs 23.991µs 5.21% 1.024 2.438 1.02% 0.016µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 41681957.172op/s 43822494.305op/s ± 442054.049op/s 43855655.358op/s ± 278349.763op/s 44133744.452op/s 44411997.865op/s 44559998.597op/s 44571401.304op/s 1.63% -0.926 1.976 1.01% 31257.942op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.614µs; 1.614µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/ throughput [619717775.117op/s; 619767630.780op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [105.034µs; 105.227µs] or [-0.092%; +0.092%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [9503789.273op/s; 9521004.376op/s] or [-0.090%; +0.090%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [97.308µs; 97.449µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 378282246310005 throughput [10262088.485op/s; 10276791.449op/s] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/37828224631 execution_time [1.613µs; 1.614µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number/37828224631 throughput [619485385.463op/s; 619825160.154op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number/378282246310005 execution_time [95.633µs; 95.830µs] or [-0.103%; +0.103%] None None None
credit_card/is_card_number/378282246310005 throughput [10435769.882op/s; 10457178.979op/s] or [-0.102%; +0.102%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [94.526µs; 94.629µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [10567768.862op/s; 10579162.141op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/x371413321323331 execution_time [22.769µs; 22.830µs] or [-0.134%; +0.134%] None None None
credit_card/is_card_number/x371413321323331 throughput [43805551.994op/s; 43922491.301op/s] or [-0.133%; +0.133%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.614µs; 1.614µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ throughput [619688508.104op/s; 619753833.694op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [86.631µs; 86.741µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [11528831.165op/s; 11543414.429op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [80.186µs; 80.350µs] or [-0.102%; +0.102%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [12446258.488op/s; 12471495.414op/s] or [-0.101%; +0.101%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.614µs; 1.614µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [619710608.091op/s; 619758488.977op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [88.433µs; 88.538µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [11294818.910op/s; 11308241.919op/s] or [-0.059%; +0.059%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [94.612µs; 94.716µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [10558061.578op/s; 10569673.433op/s] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [22.789µs; 22.854µs] or [-0.141%; +0.141%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [43761229.865op/s; 43883758.745op/s] or [-0.140%; +0.140%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.445µs 2.931µs ± 1.430µs 2.765µs ± 0.018µs 2.780µs 2.985µs 12.858µs 16.297µs 489.44% 7.995 64.098 48.66% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.732µs; 3.129µs] or [-6.761%; +6.761%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ee4339 1724352749 bob/no-memfd-fallback
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.202µs 23.170µs ± 14.580µs 17.322µs ± 0.049µs 17.397µs 52.679µs 55.968µs 131.124µs 656.99% 3.629 18.358 62.77% 1.031µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [21.149µs; 25.190µs] or [-8.721%; +8.721%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 7.93651% with 58 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (d980023) to head (6ee4339).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   72.86%   72.75%   -0.11%     
==========================================
  Files         241      241              
  Lines       34366    34427      +61     
==========================================
+ Hits        25040    25047       +7     
- Misses       9326     9380      +54     
Components Coverage Δ
crashtracker 20.66% <ø> (+0.05%) ⬆️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.12% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.11% <ø> (ø)
ddcommon-ffi 68.11% <ø> (ø)
ddtelemetry 59.02% <ø> (ø)
ipc 84.00% <50.00%> (-0.28%) ⬇️
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.23% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.18% <5.08%> (-4.69%) ⬇️
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.00% <ø> (ø)

@bwoebi bwoebi requested a review from a team as a code owner August 22, 2024 18:45
WSL is a "Linux" environment, but it does not support the memfd_create syscall. Thus we fall back to other strategies here.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit d99a69e into main Aug 22, 2024
34 checks passed
@bwoebi bwoebi deleted the bob/no-memfd-fallback branch August 22, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants