Allow using abstract namespace for crashtracker unix socket #594

bwoebi · 2024-08-22T21:52:19Z

Thanks to PrivateTmp in systemd it's pretty likely that different processes will see the same sidecar (which lives in a network namespace), but may not see the crashtracker socket in /tmp.

Defaulting to the abstract unix namespace on Linux will work around any possible problems here.

Thanks to PrivateTmp in systemd it's pretty likely that different processes will see the same sidecar (which lives in a network namespace), but may not see the crashtracker socket in /tmp. Defaulting to the abstract unix namespace on Linux will work around any possible problems here. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

codecov-commenter · 2024-08-22T22:01:29Z

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 72.85%. Comparing base (68b5d0a) to head (8656814).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
- Coverage   72.89%   72.85%   -0.04%     
==========================================
  Files         243      243              
  Lines       34638    34676      +38     
==========================================
+ Hits        25248    25262      +14     
- Misses       9390     9414      +24

Components	Coverage Δ
crashtracker	`20.44% <0.00%> (-0.18%)`	⬇️
datadog-alloc	`98.73% <ø> (ø)`
data-pipeline	`90.12% <ø> (ø)`
data-pipeline-ffi	`0.00% <ø> (ø)`
ddcommon	`82.11% <ø> (ø)`
ddcommon-ffi	`68.11% <ø> (ø)`
ddtelemetry	`59.02% <ø> (ø)`
ipc	`84.00% <ø> (ø)`
profiling	`84.26% <ø> (ø)`
profiling-ffi	`77.42% <ø> (ø)`
serverless	`0.00% <ø> (ø)`
sidecar	`40.18% <0.00%> (-0.05%)`	⬇️
sidecar-ffi	`0.00% <ø> (ø)`
spawn-worker	`50.18% <ø> (ø)`
tinybytes	`91.66% <ø> (ø)`
trace-mini-agent	`70.88% <ø> (ø)`
trace-normalization	`98.25% <ø> (ø)`
trace-obfuscation	`95.73% <ø> (ø)`
trace-protobuf	`77.67% <ø> (ø)`
trace-utils	`93.00% <ø> (-0.42%)`	⬇️

pr-commenter · 2024-08-22T22:03:09Z

Benchmarks

Comparison

Benchmark execution time: 2024-08-27 08:12:18

Comparing candidate commit 7bbfeed in PR branch bob/abstract-ns-crashtracker with baseline commit 68b5d0a in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics.

scenario:tags/replace_trace_tags

🟥 execution_time [+147.175ns; +154.251ns] or [+2.903%; +3.042%]

Candidate

Candidate benchmark details

Group 1

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
two way interface	execution_time	30.038µs	41.553µs ± 23.152µs	30.320µs ± 0.167µs	55.260µs	75.094µs	170.744µs	199.427µs	557.75%	4.099	22.614	55.58%	1.637µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
two way interface	execution_time	[38.345µs; 44.762µs] or [-7.722%; +7.722%]	None	None	None

Group 2

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	313.945µs	315.925µs ± 2.382µs	314.583µs ± 0.270µs	317.094µs	321.244µs	323.017µs	323.080µs	2.70%	1.574	1.385	0.75%	0.168µs	1	200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	3095212.609op/s	3165483.273op/s ± 23591.687op/s	3178806.894op/s ± 2732.752op/s	3180014.984op/s	3181843.615op/s	3183571.199op/s	3185267.924op/s	0.20%	-1.554	1.306	0.74%	1668.184op/s	1	200
normalization/normalize_name/normalize_name/bad-name	execution_time	34.831µs	34.924µs ± 0.051µs	34.921µs ± 0.037µs	34.960µs	34.989µs	35.108µs	35.122µs	0.58%	0.824	1.563	0.14%	0.004µs	1	200
normalization/normalize_name/normalize_name/bad-name	throughput	28471831.797op/s	28633951.393op/s ± 41561.190op/s	28635709.329op/s ± 30541.792op/s	28664916.538op/s	28693919.183op/s	28706134.774op/s	28710229.369op/s	0.26%	-0.812	1.517	0.14%	2938.820op/s	1	200
normalization/normalize_name/normalize_name/good	execution_time	23.061µs	23.347µs ± 0.054µs	23.340µs ± 0.028µs	23.379µs	23.413µs	23.453µs	23.790µs	1.93%	2.188	24.277	0.23%	0.004µs	1	200
normalization/normalize_name/normalize_name/good	throughput	42033609.373op/s	42832836.557op/s ± 98939.647op/s	42845577.136op/s ± 50964.152op/s	42893672.693op/s	42910655.558op/s	42980012.595op/s	43362783.891op/s	1.21%	-2.040	23.348	0.23%	6996.090op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	[315.595µs; 316.255µs] or [-0.105%; +0.105%]	None	None	None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	[3162213.692op/s; 3168752.854op/s] or [-0.103%; +0.103%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	execution_time	[34.917µs; 34.931µs] or [-0.020%; +0.020%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	throughput	[28628191.412op/s; 28639711.374op/s] or [-0.020%; +0.020%]	None	None	None
normalization/normalize_name/normalize_name/good	execution_time	[23.339µs; 23.354µs] or [-0.032%; +0.032%]	None	None	None
normalization/normalize_name/normalize_name/good	throughput	[42819124.473op/s; 42846548.640op/s] or [-0.032%; +0.032%]	None	None	None

Group 3

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching deserializing traces from msgpack to their internal representation	execution_time	2.208µs	2.446µs ± 0.060µs	2.467µs ± 0.024µs	2.476µs	2.509µs	2.513µs	2.514µs	1.92%	-2.669	7.774	2.46%	0.004µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching deserializing traces from msgpack to their internal representation	execution_time	[2.438µs; 2.454µs] or [-0.341%; +0.341%]	None	None	None

Group 4

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
write only interface	execution_time	3.271µs	4.085µs ± 1.498µs	3.898µs ± 0.023µs	3.919µs	4.197µs	15.698µs	16.695µs	328.30%	7.778	59.658	36.59%	0.106µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
write only interface	execution_time	[3.877µs; 4.293µs] or [-5.083%; +5.083%]	None	None	None

Group 5

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	633.006µs	635.077µs ± 2.204µs	634.970µs ± 0.293µs	635.238µs	635.555µs	635.623µs	665.466µs	4.80%	13.197	179.673	0.35%	0.156µs	1	200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	1502705.568op/s	1574629.422op/s ± 5225.729op/s	1574876.667op/s ± 726.086op/s	1575669.857op/s	1576948.083op/s	1577932.406op/s	1579764.213op/s	0.31%	-13.117	178.241	0.33%	369.515op/s	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	494.456µs	500.588µs ± 2.182µs	500.851µs ± 0.840µs	501.320µs	502.882µs	504.797µs	521.602µs	4.14%	4.297	41.644	0.43%	0.154µs	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	1917169.482op/s	1997687.261op/s ± 8553.692op/s	1996599.908op/s ± 3352.799op/s	2001692.195op/s	2009485.564op/s	2012523.018op/s	2022423.682op/s	1.29%	-3.978	37.947	0.43%	604.837op/s	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	202.933µs	203.097µs ± 0.144µs	203.098µs ± 0.089µs	203.159µs	203.324µs	203.477µs	204.318µs	0.60%	3.484	24.823	0.07%	0.010µs	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	4894335.128op/s	4923749.143op/s ± 3472.764op/s	4923730.264op/s ± 2158.963op/s	4926270.473op/s	4927090.455op/s	4927354.451op/s	4927740.081op/s	0.08%	-3.453	24.468	0.07%	245.561op/s	1	200
normalization/normalize_service/normalize_service/[empty string]	execution_time	96.662µs	98.437µs ± 0.335µs	98.392µs ± 0.126µs	98.533µs	99.071µs	99.300µs	99.349µs	0.97%	-0.590	5.500	0.34%	0.024µs	1	200
normalization/normalize_service/normalize_service/[empty string]	throughput	10065510.496op/s	10158943.661op/s ± 34606.328op/s	10163390.218op/s ± 13010.419op/s	10174881.996op/s	10188670.984op/s	10282878.010op/s	10345323.618op/s	1.79%	0.664	5.772	0.34%	2447.037op/s	1	200
normalization/normalize_service/normalize_service/test_ASCII	execution_time	59.723µs	60.172µs ± 0.116µs	60.125µs ± 0.066µs	60.218µs	60.317µs	60.391µs	61.008µs	1.47%	1.186	14.376	0.19%	0.008µs	1	200
normalization/normalize_service/normalize_service/test_ASCII	throughput	16391262.114op/s	16619189.688op/s ± 32043.082op/s	16632050.643op/s ± 18255.337op/s	16634531.570op/s	16652123.144op/s	16721426.102op/s	16743880.661op/s	0.67%	-1.100	13.890	0.19%	2265.788op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	[634.772µs; 635.383µs] or [-0.048%; +0.048%]	None	None	None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	[1573905.186op/s; 1575353.658op/s] or [-0.046%; +0.046%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	[500.286µs; 500.891µs] or [-0.060%; +0.060%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	[1996501.802op/s; 1998872.721op/s] or [-0.059%; +0.059%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	[203.077µs; 203.117µs] or [-0.010%; +0.010%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	[4923267.852op/s; 4924230.435op/s] or [-0.010%; +0.010%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	execution_time	[98.390µs; 98.483µs] or [-0.047%; +0.047%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	throughput	[10154147.557op/s; 10163739.765op/s] or [-0.047%; +0.047%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	execution_time	[60.156µs; 60.188µs] or [-0.027%; +0.027%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	throughput	[16614748.826op/s; 16623630.551op/s] or [-0.027%; +0.027%]	None	None	None

Group 6

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
credit_card/is_card_number/	execution_time	1.618µs	1.619µs ± 0.000µs	1.619µs ± 0.000µs	1.619µs	1.620µs	1.620µs	1.621µs	0.10%	0.484	-0.432	0.03%	0.000µs	1	200
credit_card/is_card_number/	throughput	617074342.119op/s	617677781.561op/s ± 184224.027op/s	617691885.985op/s ± 149316.823op/s	617833645.615op/s	617916624.107op/s	617953982.985op/s	618018826.805op/s	0.05%	-0.483	-0.435	0.03%	13026.606op/s	1	200
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	141.868µs	144.073µs ± 1.155µs	143.902µs ± 0.694µs	144.657µs	146.603µs	147.100µs	149.727µs	4.05%	1.071	2.520	0.80%	0.082µs	1	200
credit_card/is_card_number/ 3782-8224-6310-005	throughput	6678829.133op/s	6941374.833op/s ± 55170.081op/s	6949193.405op/s ± 33360.816op/s	6975232.869op/s	7008730.573op/s	7035891.540op/s	7048789.607op/s	1.43%	-0.992	2.192	0.79%	3901.114op/s	1	200
credit_card/is_card_number/ 378282246310005	execution_time	136.320µs	138.270µs ± 0.661µs	138.272µs ± 0.350µs	138.630µs	139.471µs	140.573µs	140.959µs	1.94%	0.655	3.110	0.48%	0.047µs	1	200
credit_card/is_card_number/ 378282246310005	throughput	7094236.632op/s	7232398.759op/s ± 34466.415op/s	7232108.226op/s ± 18353.358op/s	7249409.475op/s	7291995.195op/s	7321143.999op/s	7335678.540op/s	1.43%	-0.588	2.978	0.48%	2437.144op/s	1	200
credit_card/is_card_number/37828224631	execution_time	1.618µs	1.619µs ± 0.004µs	1.619µs ± 0.000µs	1.619µs	1.620µs	1.620µs	1.676µs	3.54%	13.700	188.757	0.25%	0.000µs	1	200
credit_card/is_card_number/37828224631	throughput	596575052.772op/s	617580920.293op/s ± 1505675.077op/s	617696721.115op/s ± 144176.985op/s	617840993.751op/s	617947361.908op/s	617983015.078op/s	618053958.371op/s	0.06%	-13.677	188.322	0.24%	106467.306op/s	1	200
credit_card/is_card_number/378282246310005	execution_time	131.645µs	135.478µs ± 1.471µs	135.874µs ± 1.011µs	136.259µs	137.863µs	138.205µs	138.244µs	1.74%	-0.304	-0.424	1.08%	0.104µs	1	200
credit_card/is_card_number/378282246310005	throughput	7233594.665op/s	7382123.672op/s ± 80452.020op/s	7359738.113op/s ± 54332.566op/s	7424353.088op/s	7529258.361op/s	7544375.243op/s	7596174.405op/s	3.21%	0.352	-0.396	1.09%	5688.817op/s	1	200
credit_card/is_card_number/37828224631000521389798	execution_time	132.068µs	132.810µs ± 0.512µs	132.881µs ± 0.207µs	132.966µs	133.340µs	133.424µs	137.925µs	3.80%	4.829	47.805	0.38%	0.036µs	1	200
credit_card/is_card_number/37828224631000521389798	throughput	7250328.268op/s	7529647.109op/s ± 28521.689op/s	7525524.773op/s ± 11740.310op/s	7545096.779op/s	7566312.243op/s	7567047.687op/s	7571832.028op/s	0.62%	-4.532	44.066	0.38%	2016.788op/s	1	200
credit_card/is_card_number/x371413321323331	execution_time	58.984µs	60.465µs ± 0.500µs	60.511µs ± 0.351µs	60.913µs	61.043µs	61.074µs	61.102µs	0.98%	-1.063	1.063	0.82%	0.035µs	1	200
credit_card/is_card_number/x371413321323331	throughput	16366121.576op/s	16539669.188op/s ± 137944.501op/s	16525799.520op/s ± 96252.962op/s	16617254.547op/s	16819026.511op/s	16952086.428op/s	16953644.548op/s	2.59%	1.112	1.210	0.83%	9754.149op/s	1	200
credit_card/is_card_number_no_luhn/	execution_time	1.618µs	1.619µs ± 0.000µs	1.619µs ± 0.000µs	1.619µs	1.620µs	1.620µs	1.621µs	0.11%	0.417	-0.423	0.03%	0.000µs	1	200
credit_card/is_card_number_no_luhn/	throughput	617065286.646op/s	617693556.012op/s ± 180698.722op/s	617721465.896op/s ± 142144.388op/s	617847449.294op/s	617951101.341op/s	617981514.688op/s	618018959.585op/s	0.05%	-0.416	-0.427	0.03%	12777.329op/s	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	123.736µs	125.366µs ± 0.808µs	125.451µs ± 0.499µs	125.857µs	126.852µs	126.992µs	127.059µs	1.28%	-0.089	-0.304	0.64%	0.057µs	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	7870332.340op/s	7976968.408op/s ± 51421.431op/s	7971258.432op/s ± 31580.075op/s	8017416.440op/s	8076587.534op/s	8079340.329op/s	8081745.237op/s	1.39%	0.122	-0.304	0.64%	3636.044op/s	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	117.559µs	119.274µs ± 0.577µs	119.493µs ± 0.253µs	119.607µs	119.908µs	120.494µs	120.805µs	1.10%	-0.775	0.942	0.48%	0.041µs	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	8277778.599op/s	8384286.466op/s ± 40730.584op/s	8368710.235op/s ± 17767.437op/s	8404587.858op/s	8457308.478op/s	8503263.129op/s	8506397.165op/s	1.65%	0.809	0.977	0.48%	2880.087op/s	1	200
credit_card/is_card_number_no_luhn/37828224631	execution_time	1.618µs	1.619µs ± 0.001µs	1.619µs ± 0.000µs	1.619µs	1.620µs	1.620µs	1.621µs	0.11%	0.536	0.030	0.03%	0.000µs	1	200
credit_card/is_card_number_no_luhn/37828224631	throughput	616994913.089op/s	617673568.036op/s ± 194869.982op/s	617660438.074op/s ± 164468.558op/s	617839551.841op/s	617925362.422op/s	617960953.554op/s	618037941.685op/s	0.06%	-0.535	0.026	0.03%	13779.389op/s	1	200
credit_card/is_card_number_no_luhn/378282246310005	execution_time	114.934µs	116.482µs ± 0.648µs	116.690µs ± 0.421µs	116.999µs	117.345µs	117.642µs	117.977µs	1.10%	-0.492	-0.667	0.56%	0.046µs	1	200
credit_card/is_card_number_no_luhn/378282246310005	throughput	8476228.417op/s	8585277.211op/s ± 47911.623op/s	8569733.416op/s ± 30847.492op/s	8616888.713op/s	8668151.577op/s	8682641.850op/s	8700624.462op/s	1.53%	0.510	-0.660	0.56%	3387.863op/s	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	130.870µs	132.664µs ± 0.446µs	132.868µs ± 0.068µs	132.923µs	132.971µs	133.097µs	133.880µs	0.76%	-1.430	2.160	0.34%	0.032µs	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	7469369.687op/s	7537944.167op/s ± 25464.603op/s	7526262.199op/s ± 3842.046op/s	7546985.480op/s	7583597.589op/s	7619646.388op/s	7641172.164op/s	1.53%	1.451	2.221	0.34%	1800.619op/s	1	200
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	58.996µs	60.639µs ± 0.333µs	60.711µs ± 0.234µs	60.930µs	60.963µs	60.971µs	61.002µs	0.48%	-1.220	2.576	0.55%	0.024µs	1	200
credit_card/is_card_number_no_luhn/x371413321323331	throughput	16392931.052op/s	16491540.000op/s ± 91124.716op/s	16471400.365op/s ± 63364.539op/s	16579359.066op/s	16605065.625op/s	16805755.106op/s	16950353.640op/s	2.91%	1.273	2.889	0.55%	6443.490op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
credit_card/is_card_number/	execution_time	[1.619µs; 1.619µs] or [-0.004%; +0.004%]	None	None	None
credit_card/is_card_number/	throughput	[617652249.883op/s; 617703313.240op/s] or [-0.004%; +0.004%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	[143.913µs; 144.233µs] or [-0.111%; +0.111%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	throughput	[6933728.790op/s; 6949020.875op/s] or [-0.110%; +0.110%]	None	None	None
credit_card/is_card_number/ 378282246310005	execution_time	[138.178µs; 138.361µs] or [-0.066%; +0.066%]	None	None	None
credit_card/is_card_number/ 378282246310005	throughput	[7227622.045op/s; 7237175.472op/s] or [-0.066%; +0.066%]	None	None	None
credit_card/is_card_number/37828224631	execution_time	[1.619µs; 1.620µs] or [-0.035%; +0.035%]	None	None	None
credit_card/is_card_number/37828224631	throughput	[617372248.209op/s; 617789592.378op/s] or [-0.034%; +0.034%]	None	None	None
credit_card/is_card_number/378282246310005	execution_time	[135.274µs; 135.682µs] or [-0.151%; +0.151%]	None	None	None
credit_card/is_card_number/378282246310005	throughput	[7370973.796op/s; 7393273.548op/s] or [-0.151%; +0.151%]	None	None	None
credit_card/is_card_number/37828224631000521389798	execution_time	[132.739µs; 132.881µs] or [-0.053%; +0.053%]	None	None	None
credit_card/is_card_number/37828224631000521389798	throughput	[7525694.278op/s; 7533599.941op/s] or [-0.052%; +0.052%]	None	None	None
credit_card/is_card_number/x371413321323331	execution_time	[60.396µs; 60.534µs] or [-0.115%; +0.115%]	None	None	None
credit_card/is_card_number/x371413321323331	throughput	[16520551.407op/s; 16558786.969op/s] or [-0.116%; +0.116%]	None	None	None
credit_card/is_card_number_no_luhn/	execution_time	[1.619µs; 1.619µs] or [-0.004%; +0.004%]	None	None	None
credit_card/is_card_number_no_luhn/	throughput	[617668512.907op/s; 617718599.117op/s] or [-0.004%; +0.004%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	[125.254µs; 125.478µs] or [-0.089%; +0.089%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	[7969841.893op/s; 7984094.924op/s] or [-0.089%; +0.089%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	[119.194µs; 119.354µs] or [-0.067%; +0.067%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	[8378641.599op/s; 8389931.334op/s] or [-0.067%; +0.067%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	execution_time	[1.619µs; 1.619µs] or [-0.004%; +0.004%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	throughput	[617646560.930op/s; 617700575.141op/s] or [-0.004%; +0.004%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	execution_time	[116.392µs; 116.572µs] or [-0.077%; +0.077%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	throughput	[8578637.121op/s; 8591917.301op/s] or [-0.077%; +0.077%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	[132.602µs; 132.725µs] or [-0.047%; +0.047%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	[7534415.018op/s; 7541473.316op/s] or [-0.047%; +0.047%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	[60.593µs; 60.685µs] or [-0.076%; +0.076%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	throughput	[16478910.991op/s; 16504169.009op/s] or [-0.077%; +0.077%]	None	None	None

Group 7

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
sql/obfuscate_sql_string	execution_time	109.565µs	109.903µs ± 0.193µs	109.871µs ± 0.056µs	109.934µs	110.116µs	110.590µs	111.545µs	1.52%	5.103	36.595	0.17%	0.014µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
sql/obfuscate_sql_string	execution_time	[109.876µs; 109.930µs] or [-0.024%; +0.024%]	None	None	None

Group 8

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching string interning on wordpress profile	execution_time	186.834µs	187.350µs ± 0.761µs	187.274µs ± 0.147µs	187.450µs	187.691µs	187.872µs	197.571µs	5.50%	12.226	161.705	0.40%	0.054µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching string interning on wordpress profile	execution_time	[187.245µs; 187.455µs] or [-0.056%; +0.056%]	None	None	None

Group 9

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
tags/replace_trace_tags	execution_time	5.189µs	5.221µs ± 0.016µs	5.221µs ± 0.011µs	5.232µs	5.246µs	5.255µs	5.262µs	0.79%	-0.043	-0.568	0.31%	0.001µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
tags/replace_trace_tags	execution_time	[5.218µs; 5.223µs] or [-0.043%; +0.043%]	None	None	None

Group 10

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
redis/obfuscate_redis_string	execution_time	67.229µs	67.386µs ± 0.279µs	67.330µs ± 0.036µs	67.421µs	67.504µs	67.943µs	70.571µs	4.81%	9.197	94.539	0.41%	0.020µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
redis/obfuscate_redis_string	execution_time	[67.348µs; 67.425µs] or [-0.057%; +0.057%]	None	None	None

Group 11

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	`7bbfeed`	1724677312	bob/abstract-ns-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_trace/test_trace	execution_time	434.310ns	453.001ns ± 21.729ns	453.024ns ± 14.143ns	462.007ns	485.639ns	494.170ns	668.139ns	47.48%	5.081	46.213	4.78%	1.537ns	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_trace/test_trace	execution_time	[449.990ns; 456.013ns] or [-0.665%; +0.665%]	None	None	None

Baseline

Omitted due to size.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

This reverts commit c7a60a6.

bwoebi requested review from a team as code owners August 22, 2024 21:52

github-actions bot added the sidecar label Aug 22, 2024

bantonsson approved these changes Aug 23, 2024

View reviewed changes

iamluc requested a review from a team as a code owner August 23, 2024 13:31

github-actions bot added the ci-build label Aug 23, 2024

iamluc force-pushed the bob/abstract-ns-crashtracker branch 2 times, most recently from 8397400 to 69533a1 Compare August 23, 2024 13:44

TEST with rust 1.73.0

c7a60a6

iamluc force-pushed the bob/abstract-ns-crashtracker branch from 69533a1 to c7a60a6 Compare August 23, 2024 13:58

bwoebi and others added 2 commits August 23, 2024 16:33

Append Crashtracker to file to avoid overwrites with telemetry

355367a

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

Revert "TEST with rust 1.73.0"

c4b5e72

This reverts commit c7a60a6.

github-actions bot removed the ci-build label Aug 26, 2024

Merge branch 'main' into bob/abstract-ns-crashtracker

7bbfeed

github-actions bot added the ci-build label Aug 26, 2024

iamluc force-pushed the bob/abstract-ns-crashtracker branch 2 times, most recently from c06f301 to 7bbfeed Compare August 27, 2024 06:50

github-actions bot removed the ci-build label Aug 27, 2024

iamluc requested a review from a team as a code owner August 27, 2024 07:03

github-actions bot added the ci-build label Aug 27, 2024

iamluc force-pushed the bob/abstract-ns-crashtracker branch 3 times, most recently from 8656814 to 7bbfeed Compare August 27, 2024 08:00

github-actions bot removed the ci-build label Aug 27, 2024

iamluc merged commit f55df58 into main Aug 27, 2024
86 of 88 checks passed

iamluc deleted the bob/abstract-ns-crashtracker branch August 27, 2024 08:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow using abstract namespace for crashtracker unix socket #594

Allow using abstract namespace for crashtracker unix socket #594

bwoebi commented Aug 22, 2024

codecov-commenter commented Aug 22, 2024 •

edited

Loading

pr-commenter bot commented Aug 22, 2024 •

edited

Loading

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Allow using abstract namespace for crashtracker unix socket #594

Allow using abstract namespace for crashtracker unix socket #594

Conversation

bwoebi commented Aug 22, 2024

codecov-commenter commented Aug 22, 2024 • edited Loading

Codecov Report

pr-commenter bot commented Aug 22, 2024 • edited Loading

Benchmarks

Comparison

scenario:tags/replace_trace_tags

Candidate

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Baseline

codecov-commenter commented Aug 22, 2024 •

edited

Loading

pr-commenter bot commented Aug 22, 2024 •

edited

Loading