Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental blocking socket in crashtracking #599

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Aug 27, 2024

Rust stdlib UnixListener is not async by default unlike the tokio one. It did apparently not fail during manual testing, but CI showed it sometimes failing.

Explicitly making it set_nonblocking(true).

Rust stdlib UnixListener is not async by default unlike the tokio one. It did apparently not fail during manual testing, but CI showed it sometimes failing.

Explicitly making it set_nonblocking(true).

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi requested a review from a team as a code owner August 27, 2024 13:43
@pr-commenter
Copy link

pr-commenter bot commented Aug 27, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-08-27 13:54:22

Comparing candidate commit e966b19 in PR branch bob/fix-crashtracker-nonblocking with baseline commit f55df58 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 435.150ns 450.904ns ± 11.796ns 454.125ns ± 10.532ns 458.584ns 471.717ns 472.328ns 475.227ns 4.65% 0.142 -1.225 2.61% 0.834ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [449.270ns; 452.539ns] or [-0.363%; +0.363%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 5.032µs 5.069µs ± 0.023µs 5.061µs ± 0.008µs 5.085µs 5.110µs 5.114µs 5.116µs 1.09% 0.740 -0.716 0.45% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [5.065µs; 5.072µs] or [-0.062%; +0.062%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.618µs 1.619µs ± 0.001µs 1.619µs ± 0.000µs 1.619µs 1.620µs 1.620µs 1.622µs 0.22% 1.585 7.322 0.03% 0.000µs 1 200
credit_card/is_card_number/ throughput 616348230.062op/s 617680451.657op/s ± 205380.021op/s 617711442.628op/s ± 154974.808op/s 617856070.455op/s 617925611.714op/s 617952631.764op/s 617957721.284op/s 0.04% -1.578 7.267 0.03% 14522.561op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 142.327µs 144.829µs ± 1.112µs 144.647µs ± 0.860µs 145.766µs 146.182µs 146.688µs 151.174µs 4.51% 0.596 4.037 0.77% 0.079µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 6614898.471op/s 6905101.560op/s ± 52778.498op/s 6913372.676op/s ± 40839.605op/s 6941524.266op/s 6994560.241op/s 7009796.337op/s 7026097.737op/s 1.63% -0.472 3.357 0.76% 3732.003op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 134.120µs 137.633µs ± 0.903µs 137.557µs ± 0.647µs 138.413µs 138.773µs 139.501µs 139.674µs 1.54% -0.407 0.726 0.65% 0.064µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 7159541.958op/s 7266016.165op/s ± 47783.771op/s 7269693.015op/s ± 34082.484op/s 7294458.960op/s 7339732.018op/s 7386471.517op/s 7456010.305op/s 2.56% 0.458 0.839 0.66% 3378.823op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.618µs 1.619µs ± 0.004µs 1.619µs ± 0.000µs 1.619µs 1.620µs 1.621µs 1.677µs 3.58% 13.707 188.883 0.25% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 596285077.360op/s 617514657.518op/s ± 1521452.761op/s 617634345.498op/s ± 155896.765op/s 617795186.798op/s 617872577.990op/s 617901827.779op/s 617990826.483op/s 0.06% -13.684 188.451 0.25% 107582.956op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 132.661µs 134.479µs ± 1.250µs 134.232µs ± 0.837µs 135.202µs 136.781µs 137.952µs 138.038µs 2.84% 0.658 -0.087 0.93% 0.088µs 1 200
credit_card/is_card_number/378282246310005 throughput 7244391.079op/s 7436742.555op/s ± 68710.759op/s 7449792.502op/s ± 46514.444op/s 7478818.051op/s 7531644.015op/s 7533051.682op/s 7537992.235op/s 1.18% -0.617 -0.157 0.92% 4858.584op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 131.378µs 132.684µs ± 0.543µs 132.870µs ± 0.094µs 132.927µs 132.983µs 133.013µs 138.129µs 3.96% 4.666 48.953 0.41% 0.038µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 7239601.765op/s 7536822.878op/s ± 30280.866op/s 7526134.751op/s ± 5325.488op/s 7551632.396op/s 7581275.086op/s 7583686.109op/s 7611625.235op/s 1.14% -4.319 44.786 0.40% 2141.181op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 59.228µs 60.794µs ± 0.321µs 60.923µs ± 0.113µs 60.977µs 61.098µs 61.180µs 61.471µs 0.90% -1.988 5.242 0.53% 0.023µs 1 200
credit_card/is_card_number/x371413321323331 throughput 16267823.989op/s 16449482.941op/s ± 87682.029op/s 16414167.857op/s ± 30418.245op/s 16478902.892op/s 16604037.952op/s 16795785.692op/s 16884020.288op/s 2.86% 2.041 5.530 0.53% 6200.056op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.618µs 1.619µs ± 0.001µs 1.619µs ± 0.000µs 1.619µs 1.620µs 1.620µs 1.621µs 0.11% 0.616 0.001 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 616974376.436op/s 617661126.322op/s ± 192427.677op/s 617681623.984op/s ± 151889.840op/s 617828183.903op/s 617898963.466op/s 617938157.074op/s 617985694.787op/s 0.05% -0.614 -0.003 0.03% 13606.691op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 123.779µs 126.231µs ± 0.850µs 126.227µs ± 0.756µs 127.027µs 127.438µs 127.517µs 127.550µs 1.05% -0.228 -0.943 0.67% 0.060µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 7840075.782op/s 7922320.140op/s ± 53402.969op/s 7922207.493op/s ± 47455.241op/s 7967673.192op/s 8011482.944op/s 8026447.353op/s 8078935.237op/s 1.98% 0.249 -0.915 0.67% 3776.160op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 118.157µs 119.443µs ± 0.647µs 119.442µs ± 0.477µs 120.111µs 120.224µs 120.383µs 120.539µs 0.92% -0.487 -0.783 0.54% 0.046µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 8296103.745op/s 8372441.714op/s ± 45505.143op/s 8372240.998op/s ± 33469.844op/s 8403410.104op/s 8459822.450op/s 8462369.866op/s 8463301.262op/s 1.09% 0.503 -0.766 0.54% 3217.700op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.618µs 1.620µs ± 0.002µs 1.620µs ± 0.001µs 1.622µs 1.624µs 1.626µs 1.627µs 0.49% 1.207 0.439 0.13% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 614476553.801op/s 617143313.030op/s ± 798716.309op/s 617474004.005op/s ± 330509.372op/s 617736268.360op/s 617885660.166op/s 617941869.174op/s 617959148.604op/s 0.08% -1.203 0.426 0.13% 56477.772op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 114.966µs 116.370µs ± 0.707µs 116.611µs ± 0.434µs 116.987µs 117.193µs 117.346µs 117.446µs 0.72% -0.502 -1.063 0.61% 0.050µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 8514546.368op/s 8593588.019op/s ± 52376.057op/s 8575503.421op/s ± 31795.184op/s 8636819.507op/s 8693677.747op/s 8697264.728op/s 8698258.609op/s 1.43% 0.514 -1.044 0.61% 3703.547op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 130.787µs 132.522µs ± 0.399µs 132.589µs ± 0.066µs 132.646µs 133.361µs 133.447µs 133.448µs 0.65% -0.890 3.730 0.30% 0.028µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 7493550.370op/s 7545973.359op/s ± 22785.038op/s 7542119.138op/s ± 3772.623op/s 7551816.404op/s 7582918.301op/s 7620177.049op/s 7646046.788op/s 1.38% 0.935 3.824 0.30% 1611.145op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 59.779µs 61.057µs ± 0.307µs 61.002µs ± 0.171µs 61.343µs 61.481µs 61.548µs 61.883µs 1.44% -0.431 0.833 0.50% 0.022µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 16159631.302op/s 16378494.663op/s ± 82609.020op/s 16392911.682op/s ± 46153.635op/s 16413761.686op/s 16525839.643op/s 16559021.708op/s 16728277.419op/s 2.05% 0.472 0.945 0.50% 5841.340op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.619µs; 1.619µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/ throughput [617651987.961op/s; 617708915.352op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [144.675µs; 144.983µs] or [-0.106%; +0.106%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [6897786.968op/s; 6912416.152op/s] or [-0.106%; +0.106%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [137.508µs; 137.758µs] or [-0.091%; +0.091%] None None None
credit_card/is_card_number/ 378282246310005 throughput [7259393.794op/s; 7272638.536op/s] or [-0.091%; +0.091%] None None None
credit_card/is_card_number/37828224631 execution_time [1.619µs; 1.620µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number/37828224631 throughput [617303798.798op/s; 617725516.238op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/378282246310005 execution_time [134.306µs; 134.652µs] or [-0.129%; +0.129%] None None None
credit_card/is_card_number/378282246310005 throughput [7427219.904op/s; 7446265.205op/s] or [-0.128%; +0.128%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [132.609µs; 132.759µs] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [7532626.241op/s; 7541019.515op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/x371413321323331 execution_time [60.749µs; 60.838µs] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/x371413321323331 throughput [16437331.055op/s; 16461634.827op/s] or [-0.074%; +0.074%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.619µs; 1.619µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ throughput [617634457.697op/s; 617687794.947op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [126.114µs; 126.349µs] or [-0.093%; +0.093%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [7914919.002op/s; 7929721.278op/s] or [-0.093%; +0.093%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [119.353µs; 119.533µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [8366135.139op/s; 8378748.290op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.620µs; 1.621µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [617032618.631op/s; 617254007.429op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [116.272µs; 116.468µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [8586329.201op/s; 8600846.837op/s] or [-0.084%; +0.084%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [132.467µs; 132.578µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [7542815.572op/s; 7549131.146op/s] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [61.015µs; 61.100µs] or [-0.070%; +0.070%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [16367045.847op/s; 16389943.479op/s] or [-0.070%; +0.070%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 3.249µs 4.080µs ± 1.454µs 3.909µs ± 0.018µs 3.925µs 4.143µs 14.720µs 16.745µs 328.39% 7.881 61.296 35.56% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.878µs; 4.281µs] or [-4.941%; +4.941%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 2.210µs 2.436µs ± 0.059µs 2.449µs ± 0.022µs 2.467µs 2.497µs 2.503µs 2.505µs 2.25% -2.550 7.328 2.40% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [2.428µs; 2.445µs] or [-0.333%; +0.333%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 109.359µs 109.766µs ± 0.213µs 109.757µs ± 0.107µs 109.867µs 109.961µs 110.089µs 111.383µs 1.48% 4.173 30.313 0.19% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [109.736µs; 109.795µs] or [-0.027%; +0.027%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 67.478µs 67.658µs ± 0.277µs 67.582µs ± 0.073µs 67.717µs 67.802µs 68.575µs 70.581µs 4.44% 7.819 72.550 0.41% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [67.620µs; 67.697µs] or [-0.057%; +0.057%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 186.795µs 187.443µs ± 0.254µs 187.431µs ± 0.163µs 187.603µs 187.836µs 188.205µs 188.325µs 0.48% 0.475 1.179 0.14% 0.018µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [187.408µs; 187.479µs] or [-0.019%; +0.019%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 30.444µs 43.040µs ± 25.837µs 30.593µs ± 0.090µs 57.945µs 77.509µs 181.209µs 240.744µs 686.93% 4.418 26.586 59.88% 1.827µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [39.459µs; 46.621µs] or [-8.320%; +8.320%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 314.058µs 316.101µs ± 2.509µs 314.717µs ± 0.404µs 317.448µs 322.629µs 323.094µs 323.149µs 2.68% 1.509 1.231 0.79% 0.177µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3094545.322op/s 3163739.943op/s ± 24820.264op/s 3177460.999op/s ± 4087.083op/s 3179674.882op/s 3181902.573op/s 3183742.107op/s 3184129.450op/s 0.21% -1.486 1.149 0.78% 1755.058op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 34.616µs 34.816µs ± 0.113µs 34.806µs ± 0.059µs 34.868µs 34.940µs 35.064µs 35.632µs 2.37% 3.108 19.220 0.32% 0.008µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 28064943.116op/s 28722798.689op/s ± 92425.280op/s 28730703.260op/s ± 48561.925op/s 28776823.952op/s 28833156.803op/s 28862392.969op/s 28888051.471op/s 0.55% -2.997 18.265 0.32% 6535.454op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 23.258µs 23.343µs ± 0.042µs 23.333µs ± 0.030µs 23.370µs 23.410µs 23.460µs 23.509µs 0.76% 0.709 0.665 0.18% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 42536071.475op/s 42839677.299op/s ± 77613.663op/s 42857767.869op/s ± 55638.842op/s 42901819.484op/s 42934473.471op/s 42988828.386op/s 42996292.167op/s 0.32% -0.697 0.630 0.18% 5488.115op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [315.753µs; 316.449µs] or [-0.110%; +0.110%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3160300.093op/s; 3167179.792op/s] or [-0.109%; +0.109%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [34.800µs; 34.832µs] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [28709989.435op/s; 28735607.944op/s] or [-0.045%; +0.045%] None None None
normalization/normalize_name/normalize_name/good execution_time [23.337µs; 23.349µs] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/good throughput [42828920.791op/s; 42850433.806op/s] or [-0.025%; +0.025%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz e966b19 1724766141 bob/fix-crashtracker-nonblocking
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 633.391µs 635.990µs ± 2.449µs 635.560µs ± 0.720µs 636.524µs 638.211µs 639.890µs 665.905µs 4.77% 9.266 109.615 0.38% 0.173µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1501714.905op/s 1572373.722op/s ± 5850.841op/s 1573416.633op/s ± 1785.101op/s 1574977.079op/s 1576262.922op/s 1577713.170op/s 1578803.614op/s 0.34% -8.972 104.713 0.37% 413.717op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 496.874µs 502.281µs ± 2.502µs 502.238µs ± 1.383µs 503.484µs 505.245µs 511.370µs 519.609µs 3.46% 2.114 12.741 0.50% 0.177µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 1924525.760op/s 1990964.286op/s ± 9819.521op/s 1991088.008op/s ± 5465.898op/s 1996756.623op/s 2005583.498op/s 2011714.169op/s 2012582.429op/s 1.08% -1.965 11.659 0.49% 694.345op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 202.968µs 203.196µs ± 0.879µs 203.149µs ± 0.096µs 203.203µs 203.364µs 203.398µs 215.467µs 6.06% 13.691 188.582 0.43% 0.062µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 4641077.890op/s 4921442.860op/s ± 20109.803op/s 4922502.505op/s ± 2337.890op/s 4925441.135op/s 4926163.430op/s 4926405.407op/s 4926888.819op/s 0.09% -13.649 187.805 0.41% 1421.978op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 97.548µs 99.148µs ± 0.359µs 99.183µs ± 0.208µs 99.400µs 99.616µs 99.862µs 99.906µs 0.73% -0.761 1.261 0.36% 0.025µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 10009441.163op/s 10086024.866op/s ± 36607.586op/s 10082383.646op/s ± 21050.898op/s 10102219.801op/s 10151752.510op/s 10177459.705op/s 10251360.041op/s 1.68% 0.791 1.361 0.36% 2588.547op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 60.036µs 60.195µs ± 0.067µs 60.202µs ± 0.023µs 60.218µs 60.311µs 60.410µs 60.553µs 0.58% 1.206 3.993 0.11% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 16514444.054op/s 16612668.746op/s ± 18438.101op/s 16610780.134op/s ± 6305.113op/s 16631376.054op/s 16634221.666op/s 16638133.487op/s 16656667.796op/s 0.28% -1.191 3.915 0.11% 1303.771op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [635.651µs; 636.330µs] or [-0.053%; +0.053%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1571562.851op/s; 1573184.592op/s] or [-0.052%; +0.052%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [501.935µs; 502.628µs] or [-0.069%; +0.069%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [1989603.395op/s; 1992325.178op/s] or [-0.068%; +0.068%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [203.074µs; 203.318µs] or [-0.060%; +0.060%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [4918655.834op/s; 4924229.885op/s] or [-0.057%; +0.057%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [99.099µs; 99.198µs] or [-0.050%; +0.050%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [10080951.407op/s; 10091098.326op/s] or [-0.050%; +0.050%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [60.186µs; 60.204µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [16610113.403op/s; 16615224.090op/s] or [-0.015%; +0.015%] None None None

Baseline

Omitted due to size.

Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwoebi bwoebi merged commit 0be5fad into main Aug 27, 2024
34 checks passed
@bwoebi bwoebi deleted the bob/fix-crashtracker-nonblocking branch August 27, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants