Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ifunc symbols also defined #609

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Consider ifunc symbols also defined #609

merged 2 commits into from
Sep 6, 2024

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Sep 5, 2024

Looks like php may be built with certain optimizations causing some symbols to be resolved as ifunc. The object crate is not recognizing these as definition, but for our purposes, it is one.

Fixes part of DataDog/dd-trace-php#2831.

@bwoebi bwoebi requested a review from a team as a code owner September 5, 2024 17:25
Looks like php may be built with certain optimizations causing some symbols to be resolved as ifunc.
The object crate is not recognizing these as definition, but for our purposes, it is one.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@pr-commenter
Copy link

pr-commenter bot commented Sep 5, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-09-05 19:12:53

Comparing candidate commit f802a21 in PR branch bob/handle-ifunc with baseline commit e899c91 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.512µs 2.909µs ± 1.388µs 2.749µs ± 0.020µs 2.766µs 2.996µs 12.672µs 15.701µs 471.18% 7.943 63.122 47.57% 0.098µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.717µs; 3.102µs] or [-6.610%; +6.610%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.056ms 9.104ms ± 0.015ms 9.103ms ± 0.008ms 9.110ms 9.128ms 9.145ms 9.184ms 0.89% 1.142 5.024 0.17% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.102ms; 9.106ms] or [-0.023%; +0.023%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 296.723µs 301.784µs ± 1.387µs 301.774µs ± 1.006µs 302.846µs 303.816µs 304.013µs 304.233µs 0.82% -0.519 0.034 0.46% 0.098µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3286951.606op/s 3313694.018op/s ± 15261.966op/s 3313740.957op/s ± 11079.809op/s 3323819.519op/s 3340522.850op/s 3350553.529op/s 3370150.774op/s 1.70% 0.543 0.093 0.46% 1079.184op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 28.406µs 28.590µs ± 0.087µs 28.556µs ± 0.033µs 28.612µs 28.745µs 28.911µs 28.939µs 1.34% 1.677 3.163 0.30% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 34555328.281op/s 34977922.898op/s ± 106072.240op/s 35018326.826op/s ± 40395.362op/s 35032714.777op/s 35078631.477op/s 35090825.423op/s 35204191.144op/s 0.53% -1.656 3.073 0.30% 7500.440op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.662µs 16.764µs ± 0.042µs 16.762µs ± 0.025µs 16.779µs 16.841µs 16.910µs 17.040µs 1.66% 2.267 10.355 0.25% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 58685178.805op/s 59651531.194op/s ± 148072.435op/s 59658767.281op/s ± 87767.806op/s 59760815.069op/s 59789720.073op/s 59815876.222op/s 60017115.226op/s 0.60% -2.214 9.959 0.25% 10470.302op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [301.592µs; 301.977µs] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3311578.856op/s; 3315809.179op/s] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [28.578µs; 28.602µs] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [34963222.306op/s; 34992623.490op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.758µs; 16.770µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/good throughput [59631009.779op/s; 59672052.610op/s] or [-0.034%; +0.034%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.191µs 1.365µs ± 0.053µs 1.379µs ± 0.032µs 1.405µs 1.436µs 1.452µs 1.453µs 5.34% -0.794 0.666 3.87% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.357µs; 1.372µs] or [-0.538%; +0.538%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 2.413µs 2.414µs ± 0.001µs 2.414µs ± 0.001µs 2.415µs 2.416µs 2.417µs 2.417µs 0.13% 0.878 1.232 0.03% 0.000µs 1 200
credit_card/is_card_number/ throughput 413654742.036op/s 414192802.779op/s ± 133231.449op/s 414202411.547op/s ± 97861.205op/s 414301360.819op/s 414362397.060op/s 414409935.974op/s 414443615.201op/s 0.06% -0.875 1.224 0.03% 9420.886op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 111.716µs 113.546µs ± 0.851µs 113.525µs ± 0.592µs 114.135µs 114.983µs 115.500µs 116.337µs 2.48% 0.227 -0.014 0.75% 0.060µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8595701.840op/s 8807488.582op/s ± 65940.708op/s 8808602.383op/s ± 45949.966op/s 8851824.169op/s 8915056.176op/s 8939194.911op/s 8951274.692op/s 1.62% -0.184 -0.055 0.75% 4662.712op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 107.132µs 107.853µs ± 0.413µs 107.775µs ± 0.245µs 108.063µs 108.573µs 108.935µs 109.356µs 1.47% 0.839 0.541 0.38% 0.029µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9144474.437op/s 9272042.628op/s ± 35354.127op/s 9278617.889op/s ± 21183.560op/s 9298339.320op/s 9319064.104op/s 9329068.201op/s 9334276.396op/s 0.60% -0.818 0.484 0.38% 2499.914op/s 1 200
credit_card/is_card_number/37828224631 execution_time 2.413µs 2.415µs ± 0.005µs 2.414µs ± 0.001µs 2.415µs 2.415µs 2.416µs 2.488µs 3.07% 13.701 188.784 0.22% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 401858172.007op/s 414139569.302op/s ± 880217.961op/s 414203458.640op/s ± 93735.482op/s 414297908.957op/s 414367012.698op/s 414394294.152op/s 414413671.689op/s 0.05% -13.680 188.406 0.21% 62240.809op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 104.239µs 105.080µs ± 0.437µs 104.972µs ± 0.276µs 105.336µs 105.908µs 106.145µs 106.313µs 1.28% 0.725 -0.296 0.42% 0.031µs 1 200
credit_card/is_card_number/378282246310005 throughput 9406204.901op/s 9516726.594op/s ± 39503.871op/s 9526379.693op/s ± 25141.095op/s 9547104.045op/s 9569076.763op/s 9574225.125op/s 9593381.526op/s 0.70% -0.710 -0.321 0.41% 2793.346op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 101.768µs 102.321µs ± 0.243µs 102.300µs ± 0.152µs 102.471µs 102.744µs 102.927µs 103.623µs 1.29% 1.014 3.303 0.24% 0.017µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9650344.389op/s 9773196.448op/s ± 23110.341op/s 9775182.777op/s ± 14556.597op/s 9788931.167op/s 9805471.306op/s 9816944.976op/s 9826248.859op/s 0.52% -0.984 3.149 0.24% 1634.148op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 22.051µs 23.377µs ± 0.530µs 23.369µs ± 0.349µs 23.734µs 24.287µs 24.442µs 24.489µs 4.79% -0.121 -0.445 2.26% 0.038µs 1 200
credit_card/is_card_number/x371413321323331 throughput 40834409.360op/s 42798412.665op/s ± 974757.929op/s 42792310.880op/s ± 638809.673op/s 43411916.229op/s 44437755.812op/s 44947551.010op/s 45349223.701op/s 5.98% 0.226 -0.401 2.27% 68925.794op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 2.413µs 2.414µs ± 0.001µs 2.414µs ± 0.000µs 2.415µs 2.416µs 2.417µs 2.417µs 0.11% 0.986 1.048 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 413741035.861op/s 414189835.321op/s ± 122583.809op/s 414209433.141op/s ± 83817.775op/s 414287944.225op/s 414332357.293op/s 414366366.578op/s 414381881.860op/s 0.04% -0.985 1.042 0.03% 8667.984op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 89.157µs 90.108µs ± 0.560µs 90.000µs ± 0.367µs 90.392µs 91.185µs 91.621µs 92.032µs 2.26% 0.856 0.284 0.62% 0.040µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10865741.140op/s 11098236.268op/s ± 68570.855op/s 11111143.922op/s ± 45154.588op/s 11149145.713op/s 11180500.112op/s 11195158.802op/s 11216165.829op/s 0.95% -0.828 0.215 0.62% 4848.692op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 85.336µs 86.063µs ± 0.392µs 86.060µs ± 0.243µs 86.293µs 86.579µs 86.809µs 89.223µs 3.68% 2.650 19.529 0.45% 0.028µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11207855.231op/s 11619616.744op/s ± 52269.163op/s 11619751.671op/s ± 32833.658op/s 11652737.085op/s 11693220.329op/s 11705777.063op/s 11718394.364op/s 0.85% -2.460 17.621 0.45% 3695.988op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 2.413µs 2.414µs ± 0.001µs 2.414µs ± 0.001µs 2.415µs 2.416µs 2.416µs 2.418µs 0.16% 0.873 1.641 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 413513307.320op/s 414171407.915op/s ± 135495.293op/s 414188035.668op/s ± 102123.516op/s 414285102.584op/s 414345335.950op/s 414367824.584op/s 414427231.742op/s 0.06% -0.871 1.628 0.03% 9580.964op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 82.508µs 83.095µs ± 0.288µs 83.033µs ± 0.150µs 83.271µs 83.659µs 83.822µs 84.004µs 1.17% 0.761 0.270 0.35% 0.020µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11904137.652op/s 12034561.299op/s ± 41591.055op/s 12043385.251op/s ± 21847.575op/s 12062608.928op/s 12090631.979op/s 12107398.894op/s 12119966.433op/s 0.64% -0.744 0.240 0.34% 2940.932op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 101.843µs 102.290µs ± 0.210µs 102.263µs ± 0.116µs 102.395µs 102.614µs 102.924µs 103.595µs 1.30% 1.576 6.938 0.21% 0.015µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9652968.874op/s 9776211.470op/s ± 20033.709op/s 9778728.820op/s ± 11107.015op/s 9789413.728op/s 9803317.639op/s 9817049.604op/s 9819049.939op/s 0.41% -1.537 6.673 0.20% 1416.597op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 21.851µs 22.990µs ± 0.521µs 23.014µs ± 0.378µs 23.362µs 23.887µs 24.072µs 24.173µs 5.04% 0.048 -0.508 2.26% 0.037µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 41368000.422op/s 43519472.872op/s ± 985377.830op/s 43452260.242op/s ± 718266.512op/s 44258627.808op/s 45095273.403op/s 45684410.714op/s 45764967.268op/s 5.32% 0.053 -0.502 2.26% 69676.735op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [2.414µs; 2.414µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/ throughput [414174338.182op/s; 414211267.376op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [113.428µs; 113.664µs] or [-0.104%; +0.104%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8798349.834op/s; 8816627.329op/s] or [-0.104%; +0.104%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [107.795µs; 107.910µs] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9267142.886op/s; 9276942.370op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/37828224631 execution_time [2.414µs; 2.415µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number/37828224631 throughput [414017579.559op/s; 414261559.046op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/378282246310005 execution_time [105.019µs; 105.141µs] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/378282246310005 throughput [9511251.737op/s; 9522201.450op/s] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [102.288µs; 102.355µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9769993.577op/s; 9776399.319op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/x371413321323331 execution_time [23.304µs; 23.451µs] or [-0.314%; +0.314%] None None None
credit_card/is_card_number/x371413321323331 throughput [42663320.591op/s; 42933504.739op/s] or [-0.316%; +0.316%] None None None
credit_card/is_card_number_no_luhn/ execution_time [2.414µs; 2.414µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ throughput [414172846.385op/s; 414206824.258op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [90.030µs; 90.185µs] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [11088733.007op/s; 11107739.530op/s] or [-0.086%; +0.086%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [86.009µs; 86.117µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11612372.741op/s; 11626860.748op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [2.414µs; 2.415µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [414152629.570op/s; 414190186.259op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [83.055µs; 83.135µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12028797.179op/s; 12040325.419op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [102.260µs; 102.319µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9773434.990op/s; 9778987.949op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [22.918µs; 23.062µs] or [-0.314%; +0.314%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [43382908.982op/s; 43656036.762op/s] or [-0.314%; +0.314%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 75.169µs 75.494µs ± 0.139µs 75.478µs ± 0.029µs 75.508µs 75.557µs 76.076µs 76.910µs 1.90% 7.117 62.932 0.18% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [75.475µs; 75.513µs] or [-0.026%; +0.026%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.649µs 2.684µs ± 0.016µs 2.680µs ± 0.009µs 2.693µs 2.716µs 2.718µs 2.719µs 1.46% 0.344 -0.123 0.59% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.682µs; 2.686µs] or [-0.082%; +0.082%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 16.736µs 21.741µs ± 11.610µs 16.942µs ± 0.081µs 17.071µs 49.476µs 51.315µs 100.246µs 491.71% 2.864 10.659 53.27% 0.821µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [20.132µs; 23.350µs] or [-7.401%; +7.401%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 618.455µs 619.108µs ± 0.287µs 619.123µs ± 0.194µs 619.295µs 619.542µs 619.857µs 620.128µs 0.16% 0.169 0.259 0.05% 0.020µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1612570.135op/s 1615228.162op/s ± 748.362op/s 1615188.457op/s ± 505.329op/s 1615726.752op/s 1616474.000op/s 1616824.218op/s 1616931.472op/s 0.11% -0.166 0.254 0.05% 52.917op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 466.368µs 467.938µs ± 1.386µs 467.938µs ± 0.577µs 468.396µs 469.208µs 469.693µs 484.035µs 3.44% 7.860 89.171 0.30% 0.098µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2065964.507op/s 2137054.497op/s ± 6187.881op/s 2137037.292op/s ± 2633.299op/s 2140284.135op/s 2142825.959op/s 2143790.774op/s 2144228.966op/s 0.34% -7.603 85.238 0.29% 437.549op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.588µs 191.015µs ± 0.595µs 190.971µs ± 0.075µs 191.043µs 191.216µs 191.320µs 199.182µs 4.30% 13.001 175.923 0.31% 0.042µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5020524.936op/s 5235232.636op/s ± 15683.847op/s 5236391.876op/s ± 2044.980op/s 5238493.322op/s 5241786.685op/s 5243955.289op/s 5246906.646op/s 0.20% -12.917 174.391 0.30% 1109.015op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.157µs 47.639µs ± 0.170µs 47.650µs ± 0.123µs 47.765µs 47.873µs 48.025µs 48.072µs 0.89% -0.209 0.009 0.36% 0.012µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20802008.726op/s 20991605.989op/s ± 75016.573op/s 20986206.782op/s ± 54388.409op/s 21044767.511op/s 21115924.347op/s 21186517.256op/s 21205607.434op/s 1.05% 0.230 0.021 0.36% 5304.473op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 51.470µs 51.695µs ± 0.119µs 51.687µs ± 0.072µs 51.754µs 51.866µs 51.937µs 52.689µs 1.94% 3.040 22.230 0.23% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 18979259.285op/s 19344242.176op/s ± 44403.901op/s 19347338.273op/s ± 26821.536op/s 19374894.406op/s 19396135.943op/s 19403563.787op/s 19428739.547op/s 0.42% -2.938 21.130 0.23% 3139.830op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [619.068µs; 619.147µs] or [-0.006%; +0.006%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1615124.447op/s; 1615331.878op/s] or [-0.006%; +0.006%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [467.746µs; 468.130µs] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2136196.917op/s; 2137912.078op/s] or [-0.040%; +0.040%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.933µs; 191.098µs] or [-0.043%; +0.043%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5233059.006op/s; 5237406.266op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.615µs; 47.662µs] or [-0.049%; +0.049%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [20981209.413op/s; 21002002.564op/s] or [-0.050%; +0.050%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [51.679µs; 51.712µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19338088.222op/s; 19350396.129op/s] or [-0.032%; +0.032%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 293.612ns 305.375ns ± 14.382ns 300.685ns ± 4.791ns 306.592ns 344.502ns 354.387ns 356.405ns 18.53% 2.238 4.405 4.70% 1.017ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [303.382ns; 307.368ns] or [-0.653%; +0.653%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 135.911µs 136.388µs ± 0.248µs 136.319µs ± 0.148µs 136.549µs 136.787µs 137.112µs 137.410µs 0.80% 0.885 0.950 0.18% 0.018µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [136.353µs; 136.422µs] or [-0.025%; +0.025%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz f802a21 1725563024 bob/handle-ifunc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.821µs 38.473µs ± 1.181µs 37.927µs ± 0.045µs 37.998µs 41.026µs 41.059µs 42.206µs 11.28% 1.719 1.053 3.06% 0.084µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.310µs; 38.637µs] or [-0.425%; +0.425%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.67%. Comparing base (e899c91) to head (f802a21).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   72.73%   72.67%   -0.07%     
==========================================
  Files         246      246              
  Lines       34940    34947       +7     
==========================================
- Hits        25412    25396      -16     
- Misses       9528     9551      +23     
Components Coverage Δ
crashtracker 20.38% <ø> (-0.06%) ⬇️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.12% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 82.82% <ø> (ø)
ddcommon-ffi 68.11% <ø> (ø)
ddtelemetry 59.02% <ø> (ø)
ipc 83.61% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.13% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 91.66% <ø> (ø)
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.42% <ø> (ø)

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi merged commit c48d94b into main Sep 6, 2024
30 checks passed
@bwoebi bwoebi deleted the bob/handle-ifunc branch September 6, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants