Skip to content

Allow dynamic linking on Windows #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2024
Merged

Allow dynamic linking on Windows #746

merged 4 commits into from
Nov 19, 2024

Conversation

@gleocadie
Copy link
Contributor

@gleocadie gleocadie commented Nov 18, 2024 •
edited
Loading

What does this PR do?

Update nuget package to be able to link .NET profiler dynamically against libdatadog.

Motivation

The package contained the dll but not the lib required to link dynamically in VS. The other lib file was used to link statically.

How to test the change?

The package is tested in gitlab CI. If the build is green, it means the linking was correct.
I also download the nuget packages and tested it on my machine.

@pr-commenter
Copy link

pr-commenter bot commented Nov 18, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-11-19 11:04:38

Comparing candidate commit 62cb4d5 in PR branch gleocadie/update-windows-package with baseline commit ce9ae28 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 140.698µs 142.108µs ± 0.380µs 142.171µs ± 0.189µs 142.296µs 142.553µs 143.326µs 143.758µs 1.12% 0.149 3.373 0.27% 0.027µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.055µs; 142.160µs] or [-0.037%; +0.037%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 271.976µs 274.086µs ± 1.035µs 274.003µs ± 0.670µs 274.710µs 275.974µs 276.525µs 276.778µs 1.01% 0.289 -0.362 0.38% 0.073µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3613007.405op/s 3648536.818op/s ± 13756.804op/s 3649591.526op/s ± 8928.784op/s 3658036.506op/s 3669107.104op/s 3675231.688op/s 3676793.209op/s 0.75% -0.271 -0.377 0.38% 972.753op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 25.808µs 25.925µs ± 0.065µs 25.912µs ± 0.040µs 25.966µs 26.046µs 26.075µs 26.099µs 0.72% 0.608 -0.424 0.25% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 38315328.710op/s 38573035.723op/s ± 96017.840op/s 38591636.112op/s ± 59955.185op/s 38645790.153op/s 38699214.519op/s 38738277.091op/s 38747871.583op/s 0.40% -0.599 -0.435 0.25% 6789.487op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.433µs 15.484µs ± 0.051µs 15.458µs ± 0.015µs 15.508µs 15.584µs 15.655µs 15.711µs 1.64% 1.636 2.684 0.33% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 63650009.813op/s 64582222.553op/s ± 213379.827op/s 64692485.662op/s ± 63938.518op/s 64731613.963op/s 64762595.974op/s 64769041.390op/s 64795586.125op/s 0.16% -1.617 2.579 0.33% 15088.232op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [273.943µs; 274.230µs] or [-0.052%; +0.052%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3646630.257op/s; 3650443.379op/s] or [-0.052%; +0.052%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [25.916µs; 25.934µs] or [-0.035%; +0.035%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [38559728.574op/s; 38586342.872op/s] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.477µs; 15.491µs] or [-0.046%; +0.046%] None None None
normalization/normalize_name/normalize_name/good throughput [64552650.161op/s; 64611794.945op/s] or [-0.046%; +0.046%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.026µs 27.711µs ± 11.243µs 19.311µs ± 1.006µs 36.331µs 43.712µs 45.461µs 95.891µs 396.56% 1.894 8.000 40.47% 0.795µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.153µs; 29.269µs] or [-5.623%; +5.623%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 70.206µs 70.397µs ± 0.195µs 70.382µs ± 0.045µs 70.433µs 70.485µs 70.566µs 72.975µs 3.68% 11.571 150.389 0.28% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [70.370µs; 70.424µs] or [-0.038%; +0.038%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.804ms 59.322ms ± 0.207ms 59.303ms ± 0.057ms 59.361ms 59.593ms 60.001ms 60.770ms 2.48% 2.413 14.225 0.35% 0.015ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [59.294ms; 59.351ms] or [-0.048%; +0.048%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.451µs 37.961µs ± 0.847µs 37.575µs ± 0.052µs 37.658µs 39.744µs 39.815µs 41.060µs 9.28% 1.733 1.257 2.23% 0.060µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.844µs; 38.079µs] or [-0.309%; +0.309%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 505.777µs 507.053µs ± 0.514µs 507.076µs ± 0.384µs 507.436µs 507.806µs 508.133µs 508.528µs 0.29% 0.003 -0.524 0.10% 0.036µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1966460.512op/s 1972180.773op/s ± 2000.296op/s 1972090.969op/s ± 1493.111op/s 1973724.789op/s 1975114.303op/s 1976539.281op/s 1977156.170op/s 0.26% 0.001 -0.525 0.10% 141.442op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 468.632µs 469.729µs ± 0.595µs 469.724µs ± 0.498µs 470.196µs 470.661µs 471.029µs 471.103µs 0.29% 0.213 -0.959 0.13% 0.042µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2122678.056op/s 2128892.184op/s ± 2697.869op/s 2128911.413op/s ± 2258.746op/s 2131163.704op/s 2132739.423op/s 2133507.317op/s 2133871.938op/s 0.23% -0.210 -0.962 0.13% 190.768op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.665µs 180.138µs ± 0.184µs 180.119µs ± 0.120µs 180.259µs 180.446µs 180.512µs 180.968µs 0.47% 0.479 1.225 0.10% 0.013µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5525832.864op/s 5551317.972op/s ± 5657.866op/s 5551877.249op/s ± 3691.685op/s 5555243.167op/s 5559645.663op/s 5562114.087op/s 5565926.430op/s 0.25% -0.470 1.198 0.10% 400.072op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.805µs 44.990µs ± 0.096µs 44.966µs ± 0.046µs 45.025µs 45.190µs 45.233µs 45.347µs 0.85% 0.955 0.826 0.21% 0.007µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22051954.718op/s 22227147.983op/s ± 47522.269op/s 22238791.787op/s ± 23008.725op/s 22257175.995op/s 22290356.622op/s 22316796.303op/s 22319064.803op/s 0.36% -0.943 0.800 0.21% 3360.332op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.954µs 49.148µs ± 0.118µs 49.140µs ± 0.064µs 49.206µs 49.305µs 49.371µs 50.193µs 2.14% 3.715 29.606 0.24% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19923008.121op/s 20346986.402op/s ± 48426.629op/s 20349932.654op/s ± 26663.899op/s 20376321.899op/s 20405405.244op/s 20418141.489op/s 20427310.497op/s 0.38% -3.590 28.166 0.24% 3424.280op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [506.982µs; 507.125µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1971903.551op/s; 1972457.994op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [469.646µs; 469.811µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2128518.285op/s; 2129266.083op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.112µs; 180.163µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5550533.846op/s; 5552102.098op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.977µs; 45.004µs] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22220561.853op/s; 22233734.112op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.131µs; 49.164µs] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20340274.936op/s; 20353697.867op/s] or [-0.033%; +0.033%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.351µs 3.290µs ± 1.415µs 3.141µs ± 0.023µs 3.161µs 3.215µs 13.976µs 15.030µs 378.56% 7.548 57.280 42.91% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.094µs; 3.486µs] or [-5.962%; +5.962%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.658µs 2.696µs ± 0.014µs 2.694µs ± 0.006µs 2.702µs 2.723µs 2.729µs 2.738µs 1.61% 0.104 1.310 0.51% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.694µs; 2.698µs] or [-0.071%; +0.071%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 294.053ns 306.516ns ± 15.744ns 299.390ns ± 4.192ns 310.921ns 341.350ns 348.129ns 350.872ns 17.20% 1.466 0.798 5.12% 1.113ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [304.334ns; 308.698ns] or [-0.712%; +0.712%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.017ms 9.049ms ± 0.017ms 9.049ms ± 0.009ms 9.057ms 9.075ms 9.101ms 9.149ms 1.10% 1.670 7.840 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.047ms; 9.051ms] or [-0.025%; +0.025%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 62cb4d5 1732013100 gleocadie/update-windows-package
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.599µs 4.612µs ± 0.008µs 4.611µs ± 0.006µs 4.618µs 4.628µs 4.631µs 4.632µs 0.45% 0.318 -0.693 0.18% 0.001µs 1 200
credit_card/is_card_number/ throughput 215877238.408op/s 216805434.452op/s ± 395798.484op/s 216850178.672op/s ± 292943.389op/s 217111846.887op/s 217397279.973op/s 217421630.366op/s 217423577.718op/s 0.26% -0.312 -0.700 0.18% 27987.179op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 93.272µs 93.545µs ± 0.377µs 93.472µs ± 0.110µs 93.586µs 94.128µs 94.556µs 97.637µs 4.46% 7.022 68.830 0.40% 0.027µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10242032.632op/s 10690264.727op/s ± 41919.970op/s 10698396.846op/s ± 12618.228op/s 10710018.419op/s 10717260.631op/s 10719375.488op/s 10721348.349op/s 0.21% -6.769 64.838 0.39% 2964.189op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 85.231µs 85.416µs ± 0.400µs 85.313µs ± 0.025µs 85.346µs 86.072µs 86.505µs 89.788µs 5.25% 7.282 70.901 0.47% 0.028µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11137319.468op/s 11707615.051op/s ± 53049.394op/s 11721521.484op/s ± 3439.936op/s 11724609.005op/s 11727880.399op/s 11732671.385op/s 11732756.055op/s 0.10% -7.012 66.413 0.45% 3751.159op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.594µs 4.613µs ± 0.009µs 4.613µs ± 0.006µs 4.619µs 4.628µs 4.631µs 4.639µs 0.55% 0.188 -0.625 0.19% 0.001µs 1 200
credit_card/is_card_number/37828224631 throughput 215586410.443op/s 216788196.646op/s ± 410993.421op/s 216773317.741op/s ± 301878.101op/s 217122724.682op/s 217394344.958op/s 217413836.986op/s 217652468.113op/s 0.41% -0.181 -0.634 0.19% 29061.623op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.527µs 82.030µs ± 0.224µs 82.006µs ± 0.128µs 82.135µs 82.451µs 82.638µs 82.932µs 1.13% 0.783 1.424 0.27% 0.016µs 1 200
credit_card/is_card_number/378282246310005 throughput 12058025.572op/s 12190684.798op/s ± 33181.591op/s 12194179.520op/s ± 18932.579op/s 12210330.083op/s 12240600.894op/s 12252219.024op/s 12265947.277op/s 0.59% -0.761 1.368 0.27% 2346.293op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.854µs 58.892µs ± 0.022µs 58.890µs ± 0.016µs 58.905µs 58.934µs 58.950µs 58.984µs 0.16% 0.886 0.735 0.04% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16953716.354op/s 16980191.815op/s ± 6373.830op/s 16980843.062op/s ± 4528.784op/s 16985544.877op/s 16987776.615op/s 16989396.663op/s 16991263.093op/s 0.06% -0.883 0.726 0.04% 450.698op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.819µs 6.834µs ± 0.027µs 6.823µs ± 0.003µs 6.828µs 6.892µs 6.910µs 7.039µs 3.16% 3.471 17.294 0.40% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 142060609.547op/s 146331984.539op/s ± 572000.317op/s 146556190.165op/s ± 61163.464op/s 146609778.010op/s 146636962.017op/s 146641778.742op/s 146647553.669op/s 0.06% -3.387 16.332 0.39% 40446.530op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.599µs 4.612µs ± 0.008µs 4.611µs ± 0.006µs 4.618µs 4.626µs 4.629µs 4.632µs 0.46% 0.300 -0.684 0.17% 0.001µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215867720.560op/s 216830457.361op/s ± 377030.975op/s 216860542.242op/s ± 273213.103op/s 217111933.814op/s 217392845.886op/s 217419557.081op/s 217442301.099op/s 0.27% -0.294 -0.690 0.17% 26660.116op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.341µs 73.694µs ± 0.141µs 73.716µs ± 0.085µs 73.786µs 73.852µs 73.975µs 74.521µs 1.09% 0.616 4.922 0.19% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13418955.478op/s 13569698.838op/s ± 25893.523op/s 13565489.395op/s ± 15691.311op/s 13586149.600op/s 13614800.243op/s 13622926.134op/s 13635013.351op/s 0.51% -0.579 4.710 0.19% 1830.949op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.267µs 65.427µs ± 0.118µs 65.415µs ± 0.100µs 65.521µs 65.648µs 65.684µs 65.704µs 0.44% 0.451 -0.869 0.18% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15219714.484op/s 15284352.821op/s ± 27483.750op/s 15286952.588op/s ± 23326.734op/s 15309554.311op/s 15319132.678op/s 15320384.753op/s 15321637.216op/s 0.23% -0.446 -0.876 0.18% 1943.395op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.593µs 4.613µs ± 0.009µs 4.613µs ± 0.006µs 4.619µs 4.629µs 4.631µs 4.634µs 0.46% 0.224 -0.598 0.18% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215800475.000op/s 216758606.277op/s ± 401555.111op/s 216797378.964op/s ± 279601.578op/s 217044481.185op/s 217383595.899op/s 217420350.181op/s 217706908.887op/s 0.42% -0.216 -0.601 0.18% 28394.234op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.181µs 62.496µs ± 0.069µs 62.504µs ± 0.025µs 62.526µs 62.592µs 62.640µs 62.645µs 0.23% -1.302 3.556 0.11% 0.005µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15963042.364op/s 16000950.934op/s ± 17770.289op/s 15999083.253op/s ± 6345.789op/s 16005832.125op/s 16040558.633op/s 16060169.367op/s 16082082.951op/s 0.52% 1.315 3.597 0.11% 1256.549op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.862µs 58.892µs ± 0.017µs 58.894µs ± 0.014µs 58.906µs 58.917µs 58.932µs 58.946µs 0.09% 0.336 -0.531 0.03% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16964816.667op/s 16980120.872op/s ± 5003.464op/s 16979647.346op/s ± 4130.285op/s 16984922.484op/s 16986858.966op/s 16987963.518op/s 16988811.169op/s 0.05% -0.335 -0.533 0.03% 353.798op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.819µs 6.832µs ± 0.028µs 6.823µs ± 0.003µs 6.826µs 6.900µs 6.914µs 7.045µs 3.25% 4.417 24.599 0.41% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 141947246.306op/s 146370120.351op/s ± 594609.604op/s 146555984.488op/s ± 54348.512op/s 146610266.840op/s 146634202.202op/s 146640599.721op/s 146649642.469op/s 0.06% -4.331 23.610 0.41% 42045.248op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.611µs; 4.614µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/ throughput [216750580.589op/s; 216860288.315op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [93.492µs; 93.597µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10684455.023op/s; 10696074.432op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [85.361µs; 85.472µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11700262.915op/s; 11714967.187op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631 execution_time [4.612µs; 4.614µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/37828224631 throughput [216731236.911op/s; 216845156.382op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/378282246310005 execution_time [81.999µs; 82.061µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/378282246310005 throughput [12186086.149op/s; 12195283.448op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.889µs; 58.895µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16979308.463op/s; 16981075.167op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.830µs; 6.838µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/x371413321323331 throughput [146252710.796op/s; 146411258.281op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.611µs; 4.613µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ throughput [216778204.494op/s; 216882710.228op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.674µs; 73.713µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13566110.244op/s; 13573287.431op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [65.410µs; 65.443µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15280543.838op/s; 15288161.805op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.612µs; 4.615µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216702954.600op/s; 216814257.953op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.487µs; 62.506µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15998488.143op/s; 16003413.725op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.890µs; 58.895µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16979427.440op/s; 16980814.304op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.828µs; 6.836µs] or [-0.057%; +0.057%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146287713.178op/s; 146452527.523op/s] or [-0.056%; +0.056%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.55%. Comparing base (ce9ae28) to head (62cb4d5).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
+ Coverage   70.54%   70.55%   +0.01%     
==========================================
  Files         296      296              
  Lines       43281    43281              
==========================================
+ Hits        30531    30536       +5     
+ Misses      12750    12745       -5
Components Coverage Δ
crashtracker 37.11% <ø> (ø)
crashtracker-ffi 8.67% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.95% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.86% <ø> (+0.10%) ⬆️
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.00% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.18% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.15% <ø> (ø)
---- 🚨 Try these New Features:

@gleocadie gleocadie force-pushed the gleocadie/update-windows-package branch from f2329e0 to bec1f7f Compare November 18, 2024 17:11
@gleocadie gleocadie force-pushed the gleocadie/update-windows-package branch 2 times, most recently from 9ab4a83 to c309cfc Compare November 18, 2024 21:59
@gleocadie gleocadie force-pushed the gleocadie/update-windows-package branch from c309cfc to 62cb4d5 Compare November 19, 2024 10:53
@gleocadie gleocadie marked this pull request as ready for review November 19, 2024 10:54
@gleocadie gleocadie requested a review from a team as a code owner November 19, 2024 10:54
ganeshnj
ganeshnj approved these changes Nov 19, 2024
View reviewed changes
@gleocadie gleocadie merged commit a4a3276 into main Nov 19, 2024
32 checks passed
@gleocadie gleocadie deleted the gleocadie/update-windows-package branch November 19, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoolioh hoolioh hoolioh approved these changes

+1 more reviewer

@ganeshnj ganeshnj ganeshnj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gleocadie @codecov-commenter @ganeshnj @hoolioh