Skip to content

[chore] Use elapsed() if possible when calculating durations #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2024
Merged

[chore] Use elapsed() if possible when calculating durations #750

merged 2 commits into from
Nov 20, 2024

Conversation

@danielsn
Copy link
Contributor

@danielsn danielsn commented Nov 20, 2024 •
edited
Loading

What does this PR do?

Small fixup: prefer elapsed() to Instant::now().duration_since(...)

Motivation

Its cleaner and neater.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Existing test suite

@pr-commenter
Copy link

pr-commenter bot commented Nov 20, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-11-20 20:00:54

Comparing candidate commit 9566b85 in PR branch dsn/fixup-instant with baseline commit 1b70e31 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics.

scenario:normalization/normalize_service/normalize_service/[empty string]

  • 🟥 execution_time [+13.267µs; +13.380µs] or [+28.027%; +28.266%]
  • 🟥 throughput [-4656675.879op/s; -4622472.413op/s] or [-22.043%; -21.881%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.619µs 4.634µs ± 0.005µs 4.634µs ± 0.003µs 4.636µs 4.640µs 4.655µs 4.666µs 0.71% 2.402 13.855 0.11% 0.000µs 1 200
credit_card/is_card_number/ throughput 214300815.783op/s 215813241.262op/s ± 246657.209op/s 215815161.027op/s ± 116740.982op/s 215934889.173op/s 216142284.002op/s 216224410.289op/s 216511087.364op/s 0.32% -2.367 13.629 0.11% 17441.299op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.857µs 91.769µs ± 0.559µs 91.689µs ± 0.329µs 92.044µs 92.461µs 92.669µs 96.888µs 5.67% 3.968 33.659 0.61% 0.040µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10321152.997op/s 10897322.442op/s ± 64868.208op/s 10906453.774op/s ± 39048.074op/s 10937114.637op/s 10975345.640op/s 10995400.391op/s 11006330.842op/s 0.92% -3.622 29.602 0.59% 4586.875op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 83.868µs 84.053µs ± 0.406µs 83.987µs ± 0.032µs 84.037µs 84.242µs 84.674µs 89.493µs 6.56% 12.153 159.444 0.48% 0.029µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11174067.671op/s 11897473.908op/s ± 54344.132op/s 11906564.427op/s ± 4599.117op/s 11910096.340op/s 11916075.675op/s 11922299.170op/s 11923505.940op/s 0.14% -11.952 155.687 0.46% 3842.710op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.623µs 4.634µs ± 0.006µs 4.633µs ± 0.003µs 4.636µs 4.641µs 4.648µs 4.698µs 1.39% 5.442 51.514 0.14% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 212869945.337op/s 215803684.991op/s ± 291145.139op/s 215820556.463op/s ± 125528.662op/s 215953362.088op/s 216123032.557op/s 216194322.844op/s 216320483.756op/s 0.23% -5.346 50.217 0.13% 20587.070op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.043µs 81.233µs ± 0.126µs 81.189µs ± 0.045µs 81.273µs 81.471µs 81.621µs 81.794µs 0.74% 1.585 2.460 0.15% 0.009µs 1 200
credit_card/is_card_number/378282246310005 throughput 12225907.961op/s 12310238.464op/s ± 19005.146op/s 12316951.112op/s ± 6825.099op/s 12322953.812op/s 12327582.421op/s 12333717.726op/s 12339110.193op/s 0.18% -1.577 2.417 0.15% 1343.867op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 59.020µs 59.218µs ± 0.124µs 59.231µs ± 0.114µs 59.289µs 59.435µs 59.512µs 59.572µs 0.58% 0.517 -0.682 0.21% 0.009µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16786481.419op/s 16886831.131op/s ± 35240.696op/s 16883156.523op/s ± 32645.373op/s 16919665.727op/s 16928531.602op/s 16935885.090op/s 16943279.914op/s 0.36% -0.511 -0.694 0.21% 2491.894op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.831µs 6.842µs ± 0.003µs 6.842µs ± 0.002µs 6.843µs 6.846µs 6.847µs 6.852µs 0.15% -0.249 2.525 0.04% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145943446.465op/s 146163451.990op/s ± 55553.291op/s 146162345.549op/s ± 33712.572op/s 146195231.575op/s 146237023.377op/s 146317347.083op/s 146396995.585op/s 0.16% 0.254 2.530 0.04% 3928.211op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.619µs 4.632µs ± 0.005µs 4.632µs ± 0.003µs 4.635µs 4.641µs 4.644µs 4.649µs 0.36% 0.156 0.584 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215100943.017op/s 215881169.868op/s ± 228497.946op/s 215879211.093op/s ± 141930.935op/s 216022890.023op/s 216245915.161op/s 216422912.384op/s 216492257.870op/s 0.28% -0.148 0.577 0.11% 16157.245op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.147µs 73.650µs ± 0.145µs 73.665µs ± 0.062µs 73.721µs 73.804µs 73.844µs 74.809µs 1.55% 1.697 20.242 0.20% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13367455.730op/s 13577769.861op/s ± 26703.714op/s 13574979.277op/s ± 11482.955op/s 13588355.120op/s 13622912.657op/s 13657474.244op/s 13671095.163op/s 0.71% -1.584 19.363 0.20% 1888.238op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 64.745µs 65.145µs ± 0.247µs 65.107µs ± 0.151µs 65.291µs 65.544µs 65.743µs 66.470µs 2.09% 1.199 3.546 0.38% 0.018µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15044335.363op/s 15350496.503op/s ± 58058.629op/s 15359395.168op/s ± 35719.199op/s 15390549.820op/s 15429821.602op/s 15442881.423op/s 15445174.045op/s 0.56% -1.153 3.293 0.38% 4105.365op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.623µs 4.633µs ± 0.005µs 4.633µs ± 0.003µs 4.636µs 4.641µs 4.644µs 4.647µs 0.29% 0.101 -0.047 0.10% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215213886.502op/s 215830212.019op/s ± 215779.568op/s 215831435.849op/s ± 134879.812op/s 215948032.417op/s 216201292.306op/s 216295397.574op/s 216312791.103op/s 0.22% -0.096 -0.050 0.10% 15257.920op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.877µs 63.479µs ± 0.181µs 63.513µs ± 0.098µs 63.587µs 63.695µs 63.810µs 64.192µs 1.07% -0.369 2.267 0.28% 0.013µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15578159.224op/s 15753441.379op/s ± 44962.625op/s 15744861.495op/s ± 24380.764op/s 15774704.080op/s 15837392.162op/s 15892950.852op/s 15903961.012op/s 1.01% 0.404 2.236 0.28% 3179.338op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 59.007µs 59.223µs ± 0.135µs 59.230µs ± 0.108µs 59.292µs 59.460µs 59.608µs 59.721µs 0.83% 0.844 0.814 0.23% 0.010µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16744389.366op/s 16885350.097op/s ± 38388.926op/s 16883252.664op/s ± 30765.777op/s 16918394.110op/s 16935364.174op/s 16942085.564op/s 16947021.205op/s 0.38% -0.830 0.768 0.23% 2714.507op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.831µs 6.842µs ± 0.006µs 6.841µs ± 0.002µs 6.844µs 6.850µs 6.853µs 6.899µs 0.84% 4.840 45.424 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 144951388.737op/s 146156902.465op/s ± 122917.507op/s 146173257.603op/s ± 50179.805op/s 146206831.522op/s 146306218.332op/s 146378127.984op/s 146400495.479op/s 0.16% -4.780 44.655 0.08% 8691.580op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.633µs; 4.634µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/ throughput [215779056.946op/s; 215847425.579op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [91.692µs; 91.846µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10888332.332op/s; 10906312.552op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [83.997µs; 84.110µs] or [-0.067%; +0.067%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11889942.334op/s; 11905005.482op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631 execution_time [4.633µs; 4.635µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/37828224631 throughput [215763335.075op/s; 215844034.907op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number/378282246310005 execution_time [81.216µs; 81.251µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/378282246310005 throughput [12307604.534op/s; 12312872.395op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.201µs; 59.235µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16881947.109op/s; 16891715.152op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.841µs; 6.842µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number/x371413321323331 throughput [146155752.838op/s; 146171151.141op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.632µs; 4.633µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ throughput [215849502.250op/s; 215912837.485op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.630µs; 73.670µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13574068.983op/s; 13581470.739op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [65.111µs; 65.180µs] or [-0.053%; +0.053%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15342450.136op/s; 15358542.871op/s] or [-0.052%; +0.052%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.633µs; 4.634µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [215800307.046op/s; 215860116.992op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [63.454µs; 63.504µs] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15747209.992op/s; 15759672.767op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.205µs; 59.242µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16880029.761op/s; 16890670.433op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.841µs; 6.843µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146139867.280op/s; 146173937.649op/s] or [-0.012%; +0.012%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.285µs 24.415µs ± 14.637µs 18.549µs ± 0.052µs 18.670µs 47.201µs 49.697µs 160.890µs 767.36% 5.287 40.690 59.80% 1.035µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.386µs; 26.443µs] or [-8.309%; +8.309%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.175ms 60.562ms ± 0.249ms 60.497ms ± 0.150ms 60.737ms 60.988ms 61.195ms 61.522ms 1.70% 0.919 0.513 0.41% 0.018ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.528ms; 60.597ms] or [-0.057%; +0.057%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.891µs 69.048µs ± 0.157µs 69.026µs ± 0.036µs 69.064µs 69.150µs 69.324µs 70.806µs 2.58% 8.384 84.651 0.23% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [69.026µs; 69.070µs] or [-0.031%; +0.031%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.422µs 3.242µs ± 1.451µs 3.084µs ± 0.024µs 3.105µs 3.139µs 14.266µs 15.282µs 395.52% 7.629 58.043 44.64% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.041µs; 3.443µs] or [-6.202%; +6.202%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.149ms 9.179ms ± 0.013ms 9.178ms ± 0.009ms 9.188ms 9.201ms 9.208ms 9.221ms 0.47% 0.291 0.076 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.177ms; 9.180ms] or [-0.020%; +0.020%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 303.087ns 316.281ns ± 14.023ns 310.147ns ± 5.357ns 322.182ns 350.000ns 351.064ns 356.424ns 14.92% 1.300 0.541 4.42% 0.992ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [314.337ns; 318.224ns] or [-0.614%; +0.614%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.648µs 2.698µs ± 0.017µs 2.698µs ± 0.006µs 2.704µs 2.731µs 2.736µs 2.739µs 1.50% -0.393 1.606 0.63% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.696µs; 2.700µs] or [-0.087%; +0.087%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.036µs 38.571µs ± 0.855µs 38.178µs ± 0.087µs 38.313µs 40.397µs 40.422µs 41.370µs 8.36% 1.694 1.040 2.21% 0.060µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.453µs; 38.690µs] or [-0.307%; +0.307%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 301.125µs 304.867µs ± 1.660µs 304.578µs ± 0.904µs 305.893µs 307.964µs 309.485µs 309.781µs 1.71% 0.479 0.134 0.54% 0.117µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3228090.546op/s 3280212.144op/s ± 17816.368op/s 3283226.664op/s ± 9749.300op/s 3291550.059op/s 3306104.870op/s 3314472.299op/s 3320880.882op/s 1.15% -0.448 0.101 0.54% 1259.807op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 28.077µs 28.259µs ± 0.148µs 28.212µs ± 0.086µs 28.356µs 28.526µs 28.721µs 28.763µs 1.95% 1.146 0.961 0.52% 0.010µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 34767076.043op/s 35387317.079op/s ± 184703.020op/s 35445860.806op/s ± 108788.765op/s 35531881.673op/s 35590090.425op/s 35607170.735op/s 35615734.715op/s 0.48% -1.121 0.874 0.52% 13060.476op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.541µs 16.631µs ± 0.055µs 16.628µs ± 0.045µs 16.670µs 16.723µs 16.739µs 16.744µs 0.70% 0.240 -1.155 0.33% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 59722603.291op/s 60131079.372op/s ± 198107.383op/s 60139971.492op/s ± 163906.696op/s 60316755.533op/s 60397138.699op/s 60429238.107op/s 60457465.479op/s 0.53% -0.232 -1.161 0.33% 14008.307op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [304.637µs; 305.097µs] or [-0.075%; +0.075%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3277742.966op/s; 3282681.321op/s] or [-0.075%; +0.075%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [28.239µs; 28.280µs] or [-0.073%; +0.073%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [35361719.016op/s; 35412915.141op/s] or [-0.072%; +0.072%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.623µs; 16.638µs] or [-0.046%; +0.046%] None None None
normalization/normalize_name/normalize_name/good throughput [60103623.594op/s; 60158535.150op/s] or [-0.046%; +0.046%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 137.400µs 138.238µs ± 0.333µs 138.203µs ± 0.132µs 138.354µs 138.609µs 139.389µs 141.126µs 2.11% 3.767 28.933 0.24% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [138.192µs; 138.285µs] or [-0.033%; +0.033%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9566b85 1732132205 dsn/fixup-instant
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 619.887µs 621.144µs ± 0.396µs 621.090µs ± 0.271µs 621.419µs 621.818µs 622.231µs 622.426µs 0.22% 0.477 0.367 0.06% 0.028µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1606616.690op/s 1609932.107op/s ± 1026.033op/s 1610073.540op/s ± 702.712op/s 1610705.809op/s 1611264.247op/s 1611823.076op/s 1613196.500op/s 0.19% -0.473 0.363 0.06% 72.551op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 465.997µs 466.876µs ± 0.773µs 466.849µs ± 0.220µs 467.051µs 467.344µs 468.002µs 476.716µs 2.11% 10.373 129.673 0.17% 0.055µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2097683.528op/s 2141902.322op/s ± 3487.556op/s 2142022.009op/s ± 1007.497op/s 2143104.939op/s 2144531.194op/s 2145759.653op/s 2145934.515op/s 0.18% -10.253 127.663 0.16% 246.607op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 191.345µs 191.823µs ± 1.096µs 191.734µs ± 0.110µs 191.852µs 192.119µs 192.274µs 207.041µs 7.98% 13.466 184.417 0.57% 0.078µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 4829954.910op/s 5213300.408op/s ± 27681.427op/s 5215568.246op/s ± 2987.079op/s 5218173.049op/s 5222763.718op/s 5226053.163op/s 5226171.764op/s 0.20% -13.375 182.755 0.53% 1957.372op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 59.665µs 60.661µs ± 0.380µs 60.642µs ± 0.263µs 60.934µs 61.203µs 61.309µs 62.559µs 3.16% 0.437 1.917 0.62% 0.027µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 15984855.356op/s 16485808.576op/s ± 102931.676op/s 16490246.768op/s ± 71420.348op/s 16554587.050op/s 16646505.829op/s 16692157.414op/s 16760121.934op/s 1.64% -0.369 1.637 0.62% 7278.369op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 51.405µs 51.693µs ± 0.104µs 51.683µs ± 0.064µs 51.753µs 51.874µs 51.932µs 52.056µs 0.72% 0.490 0.491 0.20% 0.007µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19209983.044op/s 19345074.515op/s ± 38871.282op/s 19348864.280op/s ± 24002.445op/s 19372126.146op/s 19396873.864op/s 19427577.073op/s 19453476.622op/s 0.54% -0.477 0.474 0.20% 2748.615op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [621.090µs; 621.199µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1609789.909op/s; 1610074.306op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [466.769µs; 466.983µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2141418.981op/s; 2142385.664op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [191.671µs; 191.975µs] or [-0.079%; +0.079%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5209464.028op/s; 5217136.787op/s] or [-0.074%; +0.074%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [60.608µs; 60.713µs] or [-0.087%; +0.087%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [16471543.236op/s; 16500073.916op/s] or [-0.087%; +0.087%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [51.679µs; 51.707µs] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19339687.329op/s; 19350461.701op/s] or [-0.028%; +0.028%] None None None

Baseline

Omitted due to size.

@danielsn danielsn marked this pull request as ready for review November 20, 2024 19:50
@danielsn danielsn requested review from a team as code owners November 20, 2024 19:50
@danielsn danielsn requested review from paullegranddc and pawelchcki and removed request for pawelchcki November 20, 2024 19:50
@danielsn danielsn enabled auto-merge (squash) November 20, 2024 20:00
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.58%. Comparing base (1b70e31) to head (9566b85).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
+ Coverage   70.55%   70.58%   +0.03%     
==========================================
  Files         296      296              
  Lines       43264    43246      -18     
==========================================
+ Hits        30524    30526       +2     
+ Misses      12740    12720      -20
Components Coverage Δ
crashtracker 37.14% <0.00%> (+0.03%) ⬆️
crashtracker-ffi 8.67% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.98% <100.00%> (+0.03%) ⬆️
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.05% <100.00%> (-0.05%) ⬇️
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <100.00%> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.86% <ø> (+0.10%) ⬆️
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.01% <0.00%> (+0.01%) ⬆️
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.36% <50.00%> (+0.17%) ⬆️
trace-normalization 98.23% <100.00%> (-0.02%) ⬇️
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.54% <ø> (ø)
---- 🚨 Try these New Features:

@danielsn danielsn merged commit c6ad4ff into main Nov 20, 2024
32 checks passed
@danielsn danielsn deleted the dsn/fixup-instant branch November 20, 2024 20:13
duncanpharvey pushed a commit that referenced this pull request Feb 20, 2025
@danielsn
[chore] Use elapsed() if possible when calculating durations (#750)
7a3b41d
duncanpharvey pushed a commit that referenced this pull request Mar 28, 2025
@danielsn
[chore] Use elapsed() if possible when calculating durations (#750)
ad3a549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekump ekump ekump approved these changes

@paullegranddc paullegranddc Awaiting requested review from paullegranddc paullegranddc was automatically assigned from DataDog/libdatadog-telemetry

+1 more reviewer

@sanchda sanchda sanchda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

data-pipeline mini-agent sidecar telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danielsn @codecov-commenter @sanchda @ekump