Small fix

DataDog · Sep 20, 2024 · 494cfaf · 494cfaf
1 parent 4ff6ada
commit 494cfaf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 16 deletions.
diff --git a/tests/condition/scalar_condition_test.cpp b/tests/condition/scalar_condition_test.cpp
@@ -82,30 +82,28 @@ TEST(TestScalarCondition, CachedMatch)
 
  ddwaf_object tmp;
  ddwaf_object root;
+ ddwaf_object_map(&root);
+ ddwaf_object_map_add(&root, "server.request.uri_raw", ddwaf_object_string(&tmp, "hello"));
 
  {
- ddwaf_object_map(&root);
- ddwaf_object_map_add(&root, "server.request.uri_raw", ddwaf_object_string(&tmp, "hello"));
-
  object_store store;
- store.insert(root);
+ store.insert(root, object_store::attribute::none, nullptr);
 
  auto res = cond.eval(cache, store, {}, {}, deadline);
  ASSERT_TRUE(res.outcome);
  ASSERT_FALSE(res.ephemeral);
  }
 
  {
- ddwaf_object_map(&root);
- ddwaf_object_map_add(&root, "server.request.uri_raw", ddwaf_object_string(&tmp, "hello"));
-
  object_store store;
- store.insert(root);
+ store.insert(root, object_store::attribute::none, nullptr);
 
  auto res = cond.eval(cache, store, {}, {}, deadline);
  ASSERT_FALSE(res.outcome);
  ASSERT_FALSE(res.ephemeral);
  }
+
+ ddwaf_object_free(&root);
 }
 
 } // namespace
diff --git a/tests/condition/scalar_negated_condition_test.cpp b/tests/condition/scalar_negated_condition_test.cpp
@@ -94,30 +94,28 @@ TEST(TestScalarNegatedCondition, CachedMatch)
 
  ddwaf_object tmp;
  ddwaf_object root;
+ ddwaf_object_map(&root);
+ ddwaf_object_map_add(&root, "server.request.uri_raw", ddwaf_object_invalid(&tmp));
 
  {
- ddwaf_object_map(&root);
- ddwaf_object_map_add(&root, "server.request.uri_raw", ddwaf_object_invalid(&tmp));
-
  object_store store;
- store.insert(root);
+ store.insert(root, object_store::attribute::none, nullptr);
 
  auto res = cond.eval(cache, store, {}, {}, deadline);
  ASSERT_TRUE(res.outcome);
  ASSERT_FALSE(res.ephemeral);
  }
 
  {
- ddwaf_object_map(&root);
- ddwaf_object_map_add(&root, "server.request.uri_raw", ddwaf_object_invalid(&tmp));
-
  object_store store;
- store.insert(root);
+ store.insert(root, object_store::attribute::none, nullptr);
 
  auto res = cond.eval(cache, store, {}, {}, deadline);
  ASSERT_FALSE(res.outcome);
  ASSERT_FALSE(res.ephemeral);
  }
+
+ ddwaf_object_free(&root);
 }
 
 } // namespace