Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Fingerprint #322

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Jul 17, 2024

No description provided.

@Anilm3 Anilm3 changed the title Session fingerprint fragment Session Fingerprint Jul 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 74.39024% with 21 lines in your changes missing coverage. Please review.

Project coverage is 84.25%. Comparing base (09cc544) to head (75420a7).

Files Patch % Lines
src/processor/fingerprint.cpp 81.33% 7 Missing and 7 partials ⚠️
src/builder/processor_builder.cpp 0.00% 4 Missing ⚠️
src/parser/processor_parser.cpp 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           anilm3/remaining-fingerprints     #322      +/-   ##
=================================================================
- Coverage                          84.31%   84.25%   -0.07%     
=================================================================
  Files                                144      144              
  Lines                               6833     6908      +75     
  Branches                            3134     3166      +32     
=================================================================
+ Hits                                5761     5820      +59     
- Misses                               402      411       +9     
- Partials                             670      677       +7     
Flag Coverage Δ
waf_test 84.25% <74.39%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jul 17, 2024

Benchmarks

Benchmark execution time: 2024-07-17 14:15:10

Comparing candidate commit 75420a7 in PR branch anilm3/session-fingerprint with baseline commit 09cc544 in branch anilm3/remaining-fingerprints.

Found 4 performance improvements and 4 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario:is_sqli_matcher.random

  • 🟩 execution_time [-164.945µs; -158.542µs] or [-3.250%; -3.124%]

scenario:is_xss_matcher.random

  • 🟥 execution_time [+5.595ms; +5.613ms] or [+6.747%; +6.770%]

scenario:lowercase_transformer.random

  • 🟥 execution_time [+167.304µs; +176.472µs] or [+9.365%; +9.878%]

scenario:regex_match_matcher.case_insensitive_flag.random

  • 🟩 execution_time [-809.136µs; -804.893µs] or [-13.832%; -13.760%]

scenario:regex_match_matcher.case_insensitive_option.random

  • 🟩 execution_time [-809.732µs; -805.165µs] or [-13.842%; -13.764%]

scenario:regex_match_matcher.lowercase_transformer.random

  • 🟩 execution_time [-619.460µs; -609.876µs] or [-8.469%; -8.338%]

scenario:remove_nulls_transformer.random

  • 🟥 execution_time [+4.132ms; +4.142ms] or [+40.439%; +40.531%]

scenario:ruleset_1.10.0.random

  • 🟥 execution_time [+17.030ms; +17.132ms] or [+6.353%; +6.391%]

@Anilm3 Anilm3 marked this pull request as ready for review July 17, 2024 14:19
@Anilm3 Anilm3 requested a review from a team as a code owner July 17, 2024 14:19
@Anilm3
Copy link
Collaborator Author

Anilm3 commented Jul 17, 2024

I'll be merging this back to #320 so it can be reviewed together.

@Anilm3 Anilm3 merged commit bfd0a5b into anilm3/remaining-fingerprints Jul 17, 2024
41 of 42 checks passed
@Anilm3 Anilm3 deleted the anilm3/session-fingerprint branch July 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants