add OpenSSL 3.3.0 #525
add OpenSSL 3.3.0 #525
Conversation
|
Reopening as part or https://datadoghq.atlassian.net/browse/BARX-389 |
chouquette
force-pushed
the
kyleneale/openssl_3.3.0
branch
from
0488353 to
ff8950d
Compare
|
Waiting for https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/38678816 to complete before merging |
config/software/openssl3.rb
Outdated
| @@ -89,8 +90,6 @@ | |||
|
|
|||
| command configure_command, env: env, in_msys_bash: true | |||
|
|
|||
| patch source: "openssl-3.0.9-do-not-build-docs.patch", env: env | |||
There was a problem hiding this comment.
I haven't checked but I suppose the patch doesn't apply anymore. I will double check
There was a problem hiding this comment.
I can't see an obvious reason not to apply the patch, I restored it and will check the pipeline
There was a problem hiding this comment.
I assumed openssl's Makefile was versionned but it isn't 🤦 I opened a new PR to have the same behavior regardless of the openssl version and will rebase this PR on top of it
chouquette
force-pushed
the
kyleneale/openssl_3.3.0
branch
from
ff8950d to
939a472
Compare
It will not be an issue, we can still select a different version that the default and add new configure arguments as required. Although the simplest approach might be to add a new software definition that would stick to the FIPS validated branch, build as usual, and copy the 2 files that are needed for FIPS |
chouquette
force-pushed
the
kyleneale/openssl_3.3.0
branch
from
939a472 to
3bd32d1
Compare
chouquette
force-pushed
the
kyleneale/openssl_3.3.0
branch
from
3bd32d1 to
2911e48
Compare
No description provided.