Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cacert: drop python2 support #549

Merged
merged 1 commit into from
Oct 11, 2024
Merged

cacert: drop python2 support #549

merged 1 commit into from
Oct 11, 2024

Conversation

chouquette
Copy link

This drops python2 support, and mostly drops the dependency on with_python_runtime? helper that is defined in the datadog-agent repo, and shouldn't be used from here

@chouquette chouquette requested a review from a team as a code owner October 11, 2024 06:40
@chouquette chouquette mentioned this pull request Oct 11, 2024
Merged
@Pythyu
Copy link

Pythyu commented Oct 11, 2024

❓ Question :
Shouldn't we keep this to be able to build new agent 6 versions (security releases) ?

@chouquette
Copy link
Author

❓ Question : Shouldn't we keep this to be able to build new agent 6 versions (security releases) ?

Those are using the stable branch origin/7.53.x) so we can remove on master

Pythyu
Pythyu approved these changes Oct 11, 2024
View reviewed changes
Copy link

@Pythyu Pythyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense 👍

@chouquette chouquette merged commit cf7fc9c into master Oct 11, 2024
3 of 4 checks passed
@chouquette chouquette deleted the chouquette/drop_python2 branch October 11, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pythyu Pythyu Pythyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chouquette @Pythyu