logs: incorrect service.name transformation

[sudomateo]

When the service.name attribute is set as a resource attribute or as an attribute on the log, the Datadog user interface shows a JSON object instead of the name of the service.

This issue actually spawns a larger discussion about how the transform function is meant to work. Specifically, the transform function retrieves the value for service, among others, from either resource attributes or attributes on the log. It then uses that service value to set the Service field on the datadogV2.HTTPLogItem. Since values can be set from both resource attributes or attributes on the log, it's not clear which method operators should be using in their code. Perhaps this should be broken out into a separate issue for further discussion. Either way, I'm bringing it up here because it was a bit confusing when reading the code.

opentelemetry-mapping-go/pkg/otlp/logs/transform.go

Lines 78 to 80 in 6e80d7e

	if service != "" {
	l.Service = datadog.PtrString(service)
	}

Here's the transform processor I used to set the service.name attribute on the log.

processors:
  transform:
    log_statements:
      - context: log
        statements:
          - set(attributes["service.name"], "sudomateo")
          - set(attributes["ddtags"], "source:sudomateo")

Notice how this appears incorrectly as a JSON object in the Datadog user interface. With this incorrect behavior I cannot use service:sudomateo to filter logs.

[liustanley]

This should be fixed in open-telemetry/opentelemetry-collector-contrib#34420.

[sudomateo]

This should be fixed in open-telemetry/opentelemetry-collector-contrib#34420.

Thank you. I'll give it a test when the beta is live then.

[liustanley]

This should be fixed in open-telemetry/opentelemetry-collector-contrib#34420.

Thank you. I'll give it a test when the beta is live then.

Sounds good, you can either wait until the beta is live or you can enable the exporter.datadogexporter.UseLogsAgentExporter feature flag to fix this issue.