-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/otlp/metrics] Fix empty exponential histogram mapping #158
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: bug_fix | ||
|
||
# The name of the component (e.g. pkg/quantile) | ||
component: pkg/otlp/metrics | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Empty OTLP Exponential Histograms are now dropped instead of causing a crash | ||
|
||
# The PR related to this change | ||
issues: [158] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
pkg/otlp/metrics/testdata/datadogdata/histogram/empty-cumulative-exponential.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{} |
1 change: 1 addition & 0 deletions
1
pkg/otlp/metrics/testdata/datadogdata/histogram/empty-delta-exponential.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{} |
38 changes: 38 additions & 0 deletions
38
pkg/otlp/metrics/testdata/otlpdata/histogram/empty-cumulative-exponential.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
{ | ||
"resourceMetrics":[ | ||
{ | ||
"resource":{ | ||
|
||
}, | ||
"scopeMetrics":[ | ||
{ | ||
"scope":{ | ||
|
||
}, | ||
"metrics":[ | ||
{ | ||
"name": "empty.exponential.cumulative.histogram", | ||
"exponentialHistogram":{ | ||
"dataPoints":[ | ||
{ | ||
"startTimeUnixNano":"1693305960229586125", | ||
"timeUnixNano":"1693305970229586125", | ||
"sum":0, | ||
"scale":4, | ||
"positive":{ | ||
|
||
}, | ||
"negative":{ | ||
|
||
} | ||
} | ||
], | ||
"aggregationTemporality":2 | ||
} | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} |
38 changes: 38 additions & 0 deletions
38
pkg/otlp/metrics/testdata/otlpdata/histogram/empty-delta-exponential.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
{ | ||
"resourceMetrics":[ | ||
{ | ||
"resource":{ | ||
|
||
}, | ||
"scopeMetrics":[ | ||
{ | ||
"scope":{ | ||
|
||
}, | ||
"metrics":[ | ||
{ | ||
"name": "empty.exponential.delta.histogram", | ||
"exponentialHistogram":{ | ||
"dataPoints":[ | ||
{ | ||
"startTimeUnixNano":"1693305960229586125", | ||
"timeUnixNano":"1693305970229586125", | ||
"sum":0, | ||
"scale":4, | ||
"positive":{ | ||
|
||
}, | ||
"negative":{ | ||
|
||
} | ||
} | ||
], | ||
"aggregationTemporality":1 | ||
} | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual fix, we were not skipping the point when the
quantile
package errored out