You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I guess we expect orchestrion execution to not happen in this case because we have no way to make sure we are running the right version of orchestrion.
Steps to reproduce the issue:
This issue only happen on certain conditions:
Need at least go 1.23
Need to use orchestrion in TOOLEXEC mode (meaning with -toolexec, not with orchestrion go ...)
Only some packages of the github.com/docker/docker repository are reproductiing this issue
Then running any integration test trying to build github.com/docker/docker reproduce the issue
The text was updated successfully, but these errors were encountered:
eliottness
changed the title
[BUG] Self-exec SEGV in toolexec mode on go 1.23 on repository with no go.mod file
[BUG] version check SEGV in toolexec mode on go 1.23
Oct 30, 2024
Ok so for some reasons, on certain builds, the go toolchain is calling go tool vet. And since the version check happen in an init function, it runs before we are able bail out. So we only have to NOT crash and return an error in the version check code and nothing more should be happening
Version of orchestrion
Latest & main
Describe what happened:
The call
tools/packages.Load
will return with no errors withpkg.Module
beingnil
. This being not checked create this error:Describe what you expected:
I guess we expect orchestrion execution to not happen in this case because we have no way to make sure we are running the right version of orchestrion.
Steps to reproduce the issue:
This issue only happen on certain conditions:
-toolexec
, not withorchestrion go ...
)github.com/docker/docker
repository are reproductiing this issueThen running any integration test trying to build
github.com/docker/docker
reproduce the issueThe text was updated successfully, but these errors were encountered: