feat: support auto-instrumentation when net/http.DefaultServeMux
is used implicitly
#440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
orchestrion
doesn't do auto-instrumentation for this code becausehandler
in http.ListenAndServe() is set tonil
. Settingnil
inhttp.ListenAndServe()
is generally a common practice.Workaround
Set
http.DefaultServeMux
tohttp.Server.Handler
explicitly.Generated code
srv.Handler
isnil
, when we setnil
inhttp.ListenAndServe()
.How I checked generated code? Use
fmt.Println(buf.String())
in /internal/injector/write.goReplace
github.com/DataDog/orchestrion
with the project in my local.