fix: failed to resolve argv0 ("/run/rosetta/rosetta") #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running orchestrion in a Docker container using a Rosetta-backed engine (using the `vz` type of VM), the `argv0` found when crawling process trees is the `binfmt` handler (`rosetta`) instead of the actual command being executed. The `rosetta` handler is only present on the hypervisor (hence it fails on `no such file or directory` during resolution attempts). When encountering not found errors on `linux/amd64` platforms, where the binary name is `rosetta`, try to resolve `argv[1]` as a fallback.
eliottness
approved these changes
Dec 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
==========================================
- Coverage 64.01% 63.91% -0.11%
==========================================
Files 184 184
Lines 11089 11098 +9
==========================================
- Hits 7099 7093 -6
- Misses 3457 3470 +13
- Partials 533 535 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running orchestrion in a Docker container using a Rosetta-backed engine (using the
vztype of VM), theargv0found when crawling process trees is thebinfmthandler (rosetta) instead of the actual command being executed.The
rosettahandler is only present on the hypervisor (hence it fails onno such file or directoryduring resolution attempts). When encountering not found errors onlinux/amd64platforms, where the binary name isrosetta, try to resolveargv[1]as a fallback.