Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add telemetry events #54

Merged
merged 3 commits into from
Feb 24, 2022
Merged

✨ Add telemetry events #54

merged 3 commits into from
Feb 24, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 22, 2022 •
edited
Loading

Motivation

With the introduction of telemetry log events, use rum-events-format to validate their structure as well.

Changes

  • Split RUM and telemetry events
  • Add telemetry error and debug schema
  • Add telemetry samples

Tests

xgouchet
xgouchet approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcaudan bcaudan marked this pull request as ready for review February 23, 2022 12:45
@bcaudan bcaudan requested review from a team as code owners February 23, 2022 12:45
ncreated
ncreated approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG and works fine with RUM generator for iOS 👍

@bcaudan bcaudan merged commit e50ce65 into master Feb 24, 2022
@bcaudan bcaudan deleted the bcaudan/add-telemetry branch February 24, 2022 13:43
@0xnm 0xnm mentioned this pull request Mar 4, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep approved these changes

@ncreated ncreated ncreated approved these changes

@xgouchet xgouchet xgouchet approved these changes

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcaudan @BenoitZugmeyer @xgouchet @ncreated @maxep