Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Catch the appropriate error in aws.execution.ec2-launch-unusual-instances (closes #387) #390

Merged
merged 1 commit into from
Jul 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,18 @@ func detonate(params map[string]string, providers stratus.CloudProviders) error
return errors.New("expected ec2:RunInstances to return an error")
}

if !strings.Contains(err.Error(), "AccessDenied") {
// We expected an *AccessDenied* error
if !isExpectedError(err) {
return errors.New("expected ec2:RunInstances to return an access denied error, got instead: " + err.Error())
}

log.Println("Got an access denied error as expected")

return nil
}

func isExpectedError(err error) bool {
// We expected an *AccessDenied* or *UnauthorizedOperation* error
errorMessage := err.Error()
return strings.Contains(errorMessage, "AccessDenied") ||
strings.Contains(errorMessage, "UnauthorizedOperation")
}