Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Add workflow to automatically create a GitHub release #129

Merged
merged 1 commit into from
Apr 28, 2023
Merged

[ci] Add workflow to automatically create a GitHub release #129

merged 1 commit into from
Apr 28, 2023

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Apr 14, 2023 •
edited
Loading

This PR adds a workflow that will be automatically run when a release PR is merged.

@Drarig29 Drarig29 changed the title Create release-version-on-merge manual workflow [ci] Add manual workflow to automatically create a release Apr 14, 2023
@Drarig29 Drarig29 changed the title [ci] Add manual workflow to automatically create a release [ci] Add workflow to automatically create a GitHub release Apr 14, 2023
@Drarig29 Drarig29 changed the base branch from main to corentin.girard/SYNTH-8788/create-bump-and-release-workflows April 14, 2023 11:25
@Drarig29 Drarig29 mentioned this pull request Apr 14, 2023
Merged
@Drarig29 Drarig29 marked this pull request as ready for review April 14, 2023 11:27
@Drarig29 Drarig29 requested a review from a team as a code owner April 14, 2023 11:27
etnbrd
etnbrd reviewed Apr 17, 2023
View reviewed changes
Copy link
Contributor

@etnbrd etnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my understanding is correct, when a branch named release/<major-minor-patch> is merged by a PR prefixed with [release:, then this workflow will create a github release named and tagged after the major-minor-patch in the branch name. Is that correct?

.github/workflows/release-version-on-merge.yml Show resolved Hide resolved
.github/workflows/release-version-on-merge.yml Show resolved Hide resolved
etnbrd
etnbrd approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@etnbrd etnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from corentin.girard/SYNTH-8788/create-bump-and-release-workflows to main April 19, 2023 12:27
@Drarig29 Drarig29 requested review from etnbrd and a team April 28, 2023 15:12
@Drarig29 Drarig29 merged commit bd6bed8 into main Apr 28, 2023
@Drarig29 Drarig29 deleted the corentin.girard/SYNTH-8789/create-on-release-pr-merged-workflow branch April 28, 2023 15:24
@Drarig29
Copy link
Contributor Author

I'll use the new authentication system in another PR.

@Drarig29 Drarig29 mentioned this pull request Apr 28, 2023
Merged
@ci-integrations-release-automation ci-integrations-release-automation bot mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etnbrd etnbrd Awaiting requested review from etnbrd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drarig29 @etnbrd