Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use volta and upgrade Yarn to 3.4.1 #133

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 requested a review from a team as a code owner April 26, 2023 13:38
"@typescript-eslint/parser": "^5.3.0",
"@vercel/ncc": "^0.31.1",
"eslint": "^7.32.0",
"eslint": "^8.39.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yarn 3 gives more information and it came up with this new warning:

$ yarn install

 YN0000:  Resolution step
 YN0060:  datadog-synthetics-github-action@workspace:. provides eslint (pe1b28) with version 7.32.0, which doesn't satisfy what eslint-plugin-github and some of its descendants request
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0000: └ Completed
➤ YN0000: Done with warnings in 0s 491ms
$ yarn explain peer-requirements pe1b28

 YN0000: datadog-synthetics-github-action@workspace:. provides eslint@npm:7.32.0 with version 7.32.0, which doesn't satisfy the following requirements:

➤ YN0000: @typescript-eslint/eslint-plugin@npm:5.3.0 [09fd5]      → ^6.0.0 || ^7.0.0 || ^8.0.0                 ✓
➤ YN0000: @typescript-eslint/experimental-utils@npm:5.3.0 [6251a] → *                                          ✓
➤ YN0000: @typescript-eslint/parser@npm:5.3.0 [09fd5]             → ^6.0.0 || ^7.0.0 || ^8.0.0                 ✓
➤ YN0000: eslint-config-prettier@npm:8.3.0 [09fd5]                → >=7.0.0                                    ✓
➤ YN0000: eslint-plugin-eslint-comments@npm:3.2.0 [09fd5]         → >=4.19.1                                   ✓
➤ YN0000: eslint-plugin-filenames@npm:1.3.2 [09fd5]               → *                                          ✓
➤ YN0000: eslint-plugin-github@npm:4.3.3 [7fc47]                  → ^8.0.1                                     ✘
➤ YN0000: eslint-plugin-i18n-text@npm:1.0.1 [09fd5]               → >=5.0.0                                    ✓
➤ YN0000: eslint-plugin-import@npm:2.25.2 [09fd5]                 → ^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8 ✓
➤ YN0000: eslint-plugin-prettier@npm:3.4.1 [09fd5]                → >=5.0.0                                    ✓
➤ YN0000: eslint-utils@npm:3.0.0 [e1cc4]                          → >=5                                        ✓

➤ YN0000: Note: these requirements start with eslint-plugin-github@npm:4.3.3 [7fc47]

Upgrading to eslint@8 fixes this issue.

@Drarig29 Drarig29 merged commit d784635 into main Apr 27, 2023
@Drarig29 Drarig29 deleted the corentin.girard/use-volta-and-upgrade-yarn branch April 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants