Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use require function in main js file instead of --require #1848

Closed
wants to merge 1 commit into from

Conversation

uurien
Copy link
Contributor

@uurien uurien commented Nov 15, 2023

Description

Prevent the use --require in nextjs system tests to require the tracer.

Motivation

In node +20, ESM hooks run in new thread, if tracer is required with --require, new instance of the tracer is started in the new thread and that causes unexpected RC messages and system test failures.
In this nodejs PR we are adding new ESM hook, and it causes some failures related with RC:

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@uurien uurien force-pushed the ugaitz/modify-nextjs-initialization branch from 5b85c6b to 36f7f56 Compare November 15, 2023 17:02
@uurien uurien closed this Jan 30, 2024
@cbeauchesne cbeauchesne deleted the ugaitz/modify-nextjs-initialization branch February 15, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant