Use Nginx Opentracing 0.34

[miry]

Motivation

In new version of Nginx Opentracing modules, there is no anymore modules for Opentracing 1.5.
It means default modules built against only with Opentracing 1.6.0

References: opentracing-contrib/nginx-opentracing#528

Solves problem #2162

cc: @cbeauchesne

Changes

Use latest Nginx Opentracing modules

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
• No system-tests internal is modified. Otherwise, I have the approval from R&P team
• CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
• A docker base image is modified?
  • the relevant build-XXX-image label is present
  • To R&P team: locally build and push the image to hub.docker.com
• A scenario is added (or removed)?
  • Get a review from R&P team
  • Once merged, add (or remove) it in system-test-dasboard nightly

[cbeauchesne]

Thanks @miry , there are two small modif to do to fix that, closing in favor of #2165

[miry]

Strange behaviour. How #2165 is different from my changes?
Ideally I expect at least cherry-pick my changes in your branch
or at least share steps to make it valubale for merging.

I would like to learn more about "there are two small modif to do to fix that".

Some my feelings are hurt, I spent my time to help you with the project and would not expect stealing my work.

[cbeauchesne]

Sorry @miry, my intention was definitely not to hurt you.

The two changes are :

1. A ot16 mention was left on line 22
2. and the 1.17.3 version of nginx support is not int available assets of opentracing-contrib/nginx-opentracing, so I need to bump the version of nginx.
   • this second change trigger another issue on glibc version, that I need to understand and fix (see my comment on the other PR).

Furthermore, it been a while I wanted to remove the hardcoded nginx version, so it was a good time to do so.

As our CI does not trigger on contributions from external contributors (security concerns on secrets), it's way easier and efficient to move forward like this.

Though, I really appreciate the time you spent trying to fix the issue here, I'll try to not forget to mention the initial PR if it happens again.