Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametric: validate span sent to agent in otel span context test #2548

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jun 11, 2024

Motivation

Ensure the OpenTelemetry SpanContext API test validates the span and trace ids that were sent to the agent.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur force-pushed the munir/verify-span-context branch 2 times, most recently from 655492e to 4a6d8dd Compare June 18, 2024 16:02
@mabdinur mabdinur force-pushed the munir/verify-span-context branch from 4a6d8dd to a6b4ee0 Compare June 18, 2024 16:04
@mabdinur mabdinur changed the title parametric: otel span context real test parametric: traces sent to agent in test_otel_get_span_context Jun 18, 2024
@mabdinur mabdinur changed the title parametric: traces sent to agent in test_otel_get_span_context parametric: validate traces sent to agent in otel span context test Jun 18, 2024
@mabdinur mabdinur changed the title parametric: validate traces sent to agent in otel span context test parametric: validate span sent to agent in otel span context test Jun 18, 2024
@mabdinur mabdinur marked this pull request as ready for review June 18, 2024 16:24
@mabdinur mabdinur requested review from Kyle-Verhoog and a team as code owners June 18, 2024 16:24
@mabdinur mabdinur merged commit 0f27f20 into main Jun 20, 2024
316 of 319 checks passed
@mabdinur mabdinur deleted the munir/verify-span-context branch June 20, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants