-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parametric: validate span sent to agent in otel span context test #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
commented
Jun 18, 2024
mabdinur
commented
Jun 18, 2024
mabdinur
commented
Jun 18, 2024
mabdinur
commented
Jun 18, 2024
mabdinur
commented
Jun 18, 2024
mabdinur
force-pushed
the
munir/verify-span-context
branch
2 times, most recently
from
June 18, 2024 16:02
655492e
to
4a6d8dd
Compare
mabdinur
force-pushed
the
munir/verify-span-context
branch
from
June 18, 2024 16:04
4a6d8dd
to
a6b4ee0
Compare
mabdinur
changed the title
parametric: otel span context real test
parametric: traces sent to agent in test_otel_get_span_context
Jun 18, 2024
mabdinur
changed the title
parametric: traces sent to agent in test_otel_get_span_context
parametric: validate traces sent to agent in otel span context test
Jun 18, 2024
mabdinur
changed the title
parametric: validate traces sent to agent in otel span context test
parametric: validate span sent to agent in otel span context test
Jun 18, 2024
robertomonteromiguel
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure the OpenTelemetry SpanContext API test validates the span and trace ids that were sent to the agent.
Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
run-parametric-scenario
,run-profiling-scenario
...) are presents[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present